Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashing of debug break message. #220

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Flashing of debug break message. #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cleo_plugins/DebugUtils/DebugUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ class DebugUtils
screenLog.Draw();

// draw active breakpoints list
if(!pausedScripts.empty())
if (!pausedScripts.empty() &&
(CTimer::m_FrameCounter & 0xE) != 0) // flashing
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be distracting/annoying?
should we consider an option to toggle it?

Copy link
Collaborator Author

@MiranDMC MiranDMC Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is frozen, there is not much to be distracted from. I caught myself several times on thinking game just crashed.
Flashing is more like text disappearing for every 16th frame, so it draws attention but still is readable.
Only active break point list on the right side of the screen is flashing.

{
for (size_t i = 0; i < pausedScripts.size(); i++)
{
Expand Down