Path validation fixes

[MiranDMC]

No description provided.

[x87]

why not

        OPCODE_READ_PARAM_FILEPATH(path);

        HMODULE ptr = LoadLibrary(path);
        if (ptr != nullptr)
        {
            m_libraries.insert(ptr);
        }
        OPCODE_WRITE_PARAM_PTR(ptr);
        OPCODE_CONDITION_RESULT(ptr != nullptr);
        return OR_CONTINUE;

[MiranDMC]

What about LoadLibrary("kernel32.dll") ?

[x87]

I assume the path shouldn't change and remain "kernel32.dll"?

[MiranDMC]

If you change work dir with 0A99 it will be added at the beginning then. That function did not used path reading macro on purpose.

[x87]

Wdym? If workdir is within game directory it will stripped from the path.

[MiranDMC]

ML seems unable to install its hooks if library passed to LoadLibrary is not relative path. It happens when loading cleo plugins too.
I think CLEO_ResolvePath will still resolve some paths as absolute. Like virtual "cleo:"

[x87]

ML has nothing to do with virtual/absolute paths. What script was reported not working to make this change?

[x87]

Can you revert the change to 0AA2?

[MiranDMC]

ML has nothing to do with virtual/absolute paths. What script was reported not working to make this change?

https://github.com/cleolibrary/CLEO5/blob/master/source/CScriptEngine.cpp#L682
Perhaps if changed it will become dead loop in some cases, as resolved path will still be seen as not resolved.

[x87]

If we want to make virtual path ML-compatible (i.g. relative to game dir), then we should do it in ResolvePath. stream_custom_script "cleo:\1.cs" and load_library "cleo:\1.dll" should work the same.