Bump artifact actions to v4

.github/workflows/all.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   lint:
     name: Lint
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -25,7 +25,7 @@ jobs:
   push_translations:
     name: Push translation sources to Transifex
     if: github.ref == 'refs/heads/master'
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: ubuntu:bionic
     steps:
@@ -94,10 +94,9 @@ jobs:
 
   create_release:
     name: Create GitHub Release
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     if: github.ref == 'refs/heads/master'
     needs:
-      - build_bionic_64
       - build_bullseye_64
       - build_buster_64
       - build_fedora_36
@@ -110,7 +109,7 @@ jobs:
       - build_source
     steps:
       - uses: actions/[email protected]
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           path: release_artifacts
       - name: Create draft pre-release
@@ -129,7 +128,7 @@ jobs:
 
   build_source:
     name: Build source tarball
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: ubuntu:focal
     steps:
@@ -182,14 +181,14 @@ jobs:
       - name: Build source tarball
         working-directory: bin
         run: ../dist/maketarball.sh
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_source
           path: bin/clementine-*.tar.xz
 
   build_fedora_36:
     name: Build Fedora 36 RPM
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: fedora:36
     env:
@@ -256,14 +255,14 @@ jobs:
       - name: Build RPM
         working-directory: bin
         run: rpmbuild -ba ../dist/clementine.spec
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_fedora_36
           path: ~/rpmbuild/RPMS/*/clementine-*.rpm
 
   build_fedora_37:
     name: Build Fedora 37 RPM
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: fedora:37
     env:
@@ -330,14 +329,14 @@ jobs:
       - name: Build RPM
         working-directory: bin
         run: rpmbuild -ba ../dist/clementine.spec
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_fedora_37
           path: ~/rpmbuild/RPMS/*/clementine-*.rpm
 
   build_fedora_38:
     name: Build Fedora 38 RPM
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: fedora:38
     env:
@@ -404,15 +403,15 @@ jobs:
       - name: Build RPM
         working-directory: bin
         run: rpmbuild -ba ../dist/clementine.spec
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_fedora_38
           path: ~/rpmbuild/RPMS/*/clementine-*.rpm
 
 
   build_mingw:
     name: Build Windows Installer
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: eu.gcr.io/clementine-data/mingw-w64:latest
     env:
@@ -598,73 +597,14 @@ jobs:
       - name: Build Windows installer
         working-directory: dist/windows
         run: makensis clementine.nsi
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_mingw
           path: dist/windows/ClementineSetup*.exe
 
-  build_bionic_64:
-    name: Build Ubuntu Bionic 64-bit deb
-    runs-on: ubuntu-22.04
-    container:
-      image: ubuntu:bionic
-    steps:
-      - name: Install dependencies
-        env:
-          DEBIAN_FRONTEND: noninteractive
-        run: >
-          apt-get update && apt-get install -y
-          build-essential
-          cmake
-          gettext
-          git
-          libasound2-dev
-          libboost-dev
-          libcdio-dev
-          libchromaprint-dev
-          libdbus-1-dev
-          libfftw3-dev
-          libglew1.5-dev
-          libglib2.0-dev
-          libgpod-dev
-          libgstreamer-plugins-base1.0-dev
-          libgstreamer1.0-dev
-          liblastfm5-dev
-          libmtp-dev
-          libprotobuf-dev
-          libpulse-dev
-          libqt5x11extras5-dev
-          libsqlite3-dev
-          libtag1-dev
-          pkg-config
-          protobuf-compiler
-          qtbase5-dev
-          qttools5-dev-tools
-          qttools5-dev
-          libsparsehash-dev
-          ssh
-      - uses: actions/[email protected]
-      - name: git hackery
-        run: git config --global --add safe.directory ${GITHUB_WORKSPACE}
-      - name: cmake
-        working-directory: bin
-        run: >
-          cmake ..
-          -DWITH_DEBIAN=ON
-          -DDEB_ARCH=amd64
-          -DDEB_DIST=bionic
-          -DENABLE_SPOTIFY_BLOB=OFF
-      - name: make
-        working-directory: bin
-        run : make -j2 deb
-      - uses: actions/upload-artifact@v2
-        with:
-          name: release_bionic_64
-          path: bin/clementine_*.deb
-
   build_bullseye_64:
     name: Build Debian Bullseye 64-bit deb
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: debian:bullseye
     steps:
@@ -717,14 +657,14 @@ jobs:
       - name: make
         working-directory: bin
         run : make -j2 deb
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_bullseye_64
           path: bin/clementine_*.deb
 
   build_buster_64:
     name: Build Debian Buster 64-bit deb
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: debian:buster
     steps:
@@ -776,14 +716,14 @@ jobs:
       - name: make
         working-directory: bin
         run : make -j2 deb
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_buster_64
           path: bin/clementine_*.deb
 
   build_focal_64:
     name: Build Ubuntu Focal 64-bit deb
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: ubuntu:focal
     steps:
@@ -841,14 +781,14 @@ jobs:
       - name: make
         working-directory: bin
         run : make -j2 deb
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_focal_64
           path: bin/clementine_*.deb
 
   build_jammy_64:
     name: Build Ubuntu Jammy 64-bit deb
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     container:
       image: ubuntu:jammy
     steps:
@@ -909,7 +849,7 @@ jobs:
       - name: make
         working-directory: bin
         run : make -j2 deb
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_jammy_64
           path: bin/clementine_*.deb
@@ -976,7 +916,7 @@ jobs:
       - name: Build DMG
         working-directory: bin
         run: make dmg
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: release_mac
           path: bin/clementine-*.dmg