Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move constants into proxy code file where they are used to prevent accidental overwriting #6

Merged
merged 5 commits into from
Feb 8, 2024
Merged

move constants into proxy code file where they are used to prevent accidental overwriting #6

merged 5 commits into from
Feb 8, 2024

Conversation

sgtsquiggs
Copy link
Contributor

  • moves constants into proxy output file to avoid overwriting when running reinforcer separately per proxy

@sgtsquiggs sgtsquiggs self-assigned this Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7821915415

  • 0 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 77.408%
Totals Coverage Status
Change from base Build 7731498877: 0.04%
Covered Lines: 675
Relevant Lines: 872
💛 - Coveralls

@sgtsquiggs sgtsquiggs changed the title move constants into proxy code to avoid overwriting move constants into proxy code file where they are used to prevent accidental overwriting Feb 5, 2024
@sgtsquiggs sgtsquiggs marked this pull request as ready for review February 5, 2024 21:13
@sgtsquiggs sgtsquiggs merged commit 3d53d07 into develop Feb 8, 2024
11 checks passed
@sgtsquiggs sgtsquiggs deleted the bundle-constants-with-proxy-code branch February 8, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzachshabtay tzachshabtay tzachshabtay approved these changes

@ethanrgrant ethanrgrant ethanrgrant approved these changes

@rtjoseph11 rtjoseph11 Awaiting requested review from rtjoseph11

Assignees

@sgtsquiggs sgtsquiggs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgtsquiggs @tzachshabtay @ethanrgrant