Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generics support #4

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Generics support #4

merged 4 commits into from
Jan 31, 2024

Conversation

sgtsquiggs
Copy link
Contributor

@sgtsquiggs sgtsquiggs commented Jan 27, 2024 •
edited
Loading

  • Adds support for generics
  • Moves toType util function to types package and makes it public
  • Tests updated w/ generic cases
  • Bumps golangci-lint in ci workflow to 1.54

@sgtsquiggs sgtsquiggs self-assigned this Jan 27, 2024
@coveralls
Copy link

coveralls commented Jan 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7705017699

  • -8 of 56 (85.71%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.9%) to 77.365%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/loader/loader.go 14 22 63.64%
Files with Coverage Reduction New Missed Lines %
internal/loader/loader.go 2 67.78%
Totals Coverage Status
Change from base Build 5426751614: 2.9%
Covered Lines: 687
Relevant Lines: 888
💛 - Coveralls

@sgtsquiggs sgtsquiggs merged commit eba1a29 into develop Jan 31, 2024
5 checks passed
@sgtsquiggs sgtsquiggs deleted the generics branch January 31, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnisenbaum1 dnisenbaum1 dnisenbaum1 approved these changes

@tzachshabtay tzachshabtay tzachshabtay approved these changes

@ethanrgrant ethanrgrant Awaiting requested review from ethanrgrant

Assignees

@sgtsquiggs sgtsquiggs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sgtsquiggs @coveralls @tzachshabtay @dnisenbaum1