Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CODEX-#369]: Refactor is_bad_response to take TLMOptions rather than a TLM model #52

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[CODEX-#369]: Refactor is_bad_response to take TLMOptions rather than a TLM model #52

wants to merge 2 commits into from

Conversation

RehanSD
Copy link
Contributor

@RehanSD RehanSD commented Feb 27, 2025 •
edited
Loading

Key Info

  • Implementation plan: link
  • Priority: normal

What changed?

Changes is_bad_response to use Codex TLM pass through instead of requiring a TLM model from the user.

What do you want the reviewer(s) to focus on?

Checklist

  • Did you link the GitHub issue?
  • Did you follow deployment steps or bump the version if needed?
  • Did you add/update tests?
  • What QA did you do?
    • Tested...

@RehanSD
Copy link
Contributor Author

RehanSD commented Feb 27, 2025

Tests + type checking will fail until codex-sdk is updated.

@RehanSD RehanSD removed the request for review from kelsey-wong February 27, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axl1313 axl1313 Awaiting requested review from axl1313

@elisno elisno Awaiting requested review from elisno

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RehanSD