CF/BF - Update configurator for API 1.33.0. #450

hydra · 2017-03-19T23:11:20Z

PR goals:

Testing is currently being done with CF 2.0.0 master.

Although some items are marked as 'from CF configurator v1.x' not that much actual js code is being used due to recent changes, however the html/css/messages are mainly work ok so the porting is manual.

hydra · 2017-03-19T23:13:42Z

Currently the most tabs are working OK.

motors tab needs fixing.
blackbox tab needs fixing.

mikeller

👍 Looks good.

mikeller · 2017-03-19T23:37:26Z

js/fc.js

@@ -182,31 +225,50 @@ var FC = {
        FC_CONFIG = {
            loopTime: 0
        };
-
-        MISC = {
+


MISC will be deleted soon 😄

mikeller · 2017-03-19T23:37:59Z

js/fc.js

            deadband3d_low:         0,
            deadband3d_high:        0,
-            neutral3d:              0,
-            deadband3d_throttle:    0
+            neutral:              0,


mikeller · 2017-03-19T23:38:10Z

js/fc.js

-            midrc:                  0,
-            mincheck:               0,
+            stick_max:               0,
+            stick_center:                  0,


there will be many spaces, i did LOTS of search and replacing today. I'll go over it again after it's functional, no point aligning things at this stage.

mikeller · 2017-03-19T23:39:02Z

js/msp.js

@@ -148,6 +148,9 @@ var MSP = {
        this.listeners = [];  
    },
    send_message: function (code, data, callback_sent, callback_msp, callback_onerror) {
+        if (code === undefined) {
+            debugger;


Intentionally throwing an exception?

yes, to catch the stacktrace, will be removed from production code.

mikeller · 2017-03-19T23:44:11Z

tabs/onboard_logging.js

@@ -110,7 +110,7 @@ TABS.onboard_logging.initialize = function (callback) {
             * The best we can do on those targets is check the BLACKBOX feature bit to identify support for Blackbox instead.
             */
            if (BLACKBOX.supported || DATAFLASH.supported 
-                    || semver.gte(CONFIG.flightControllerVersion, "1.5.0") && semver.lte(CONFIG.flightControllerVersion, "1.10.0") && BF_CONFIG.features.isEnabled('BLACKBOX')) {
+                    || semver.gte(CONFIG.flightControllerVersion, "1.5.0") && semver.lte(CONFIG.flightControllerVersion, "1.10.0") && FEATURE_CONFIG.features.isEnabled('BLACKBOX')) {


Should this be checking apiVersion instead?

probably. I'll be stripping a out all the old conditional code that's not currently getting in the way in later commits.

hydra · 2017-03-24T00:43:29Z

current status, fully working but lacks the battery/power tab to configure current/voltage sensors and battery.

hydra · 2017-04-02T11:08:50Z

rebased against master.

I'm going to de-scope this PR. what's there is fine for a release, we can do the remainder of the tasks in this PR later.

hydra · 2017-04-02T11:10:40Z

currently the code is working, there's a few minor cleanups to do which I will do now before merging to master.

1.33.0

More work is required to support ARCITIMER.

The voltage and amperage meters cannot yet be configured and are disabled.

configuration tab.

bargraph can be calculated.

betaflight. Also fix missing save of GPS and Compass configuration.

The reason is because the SPRacingF4EVO shipped with cf 1.33.0 (rc1), this forces the user to upgrade and ensures those users don't have a broken experiance.

…ght-versions Corrections to some BetaFlight references

open.

* Replaces Setup tab with Setup OSD tab for OSD Slave boards - ported from CF v1.x. * Disables CLI tab for OSD Slave boards - due to cleanflight/cleanflight#2710 *

Slave boards.

hydra · 2017-04-12T19:23:38Z

only thing really missing right now is current and voltage meter configuration. what's done so far needs to be released - will follow up with another PR for additional work/features.

mikeller reviewed Mar 19, 2017

View reviewed changes

hydra added the Work-in-progress label Mar 20, 2017

hydra force-pushed the update-for-api-1.33.0 branch 3 times, most recently from c968978 to 5926b54 Compare March 23, 2017 21:23

hydra force-pushed the update-for-api-1.33.0 branch 2 times, most recently from 391db81 to 0339208 Compare April 1, 2017 15:53

hydra mentioned this pull request Apr 1, 2017

Support for next lap timer #445

Closed

hydra force-pushed the update-for-api-1.33.0 branch 2 times, most recently from b497434 to 0ebdeac Compare April 2, 2017 11:06

hydra force-pushed the update-for-api-1.33.0 branch from eaa7f0d to d9d3b6d Compare April 2, 2017 11:19

hydra added Requires feedback Requires testing and removed Work-in-progress Requires feedback labels Apr 2, 2017

hydra and others added 11 commits April 2, 2017 18:33

CF/BF - Update configurator for API 1.33.0.

7c6210b

CF/BF - Delete unused angleAtMin/Max from configurator to match API

8cc5aaf

1.33.0

CF/BF - fix blackbox logging to use the right device numbers.

16cb25b

CF/BF - Support configuration of iLAP transponder code.

bea75cc

More work is required to support ARCITIMER.

CF/BF - Add VTX to features list.

da35c80

CF/BF - Initial port of power/battery tab from CF 1.x.

f74fba1

The voltage and amperage meters cannot yet be configured and are disabled.

CF/BF - Delete the old battery/current/voltage settings from the

fdc64b3

configuration tab.

CF/BF - Allow mixer to be changed - due to removal of MSP_MISC.

e2219b9

CF/BF - delete old unused commented out code.

ee77500

CF/BF - ensure battery config is checked on connect so the battery

5191381

bargraph can be calculated.

CF/BF - Reinstate support for MSP_MISC and some older versions of

d7e2701

betaflight. Also fix missing save of GPS and Compass configuration.

CF/BF - Limit support to CF v2.0.0 onwards and BF v3.0.0 onwards ONLY.

6fdbab1

hydra force-pushed the update-for-api-1.33.0 branch from 4725f74 to 0b779ff Compare April 2, 2017 17:33

hydra added 5 commits April 2, 2017 19:31

CF/BF - Bump API version for power and battery tab to be 1.33.0.

dd12005

CF/BF - add more translations for ESC voltage/current meters.

ebaa46e

CF/BF - Update OSD examples to match latest firmware.

a86ba3b

CF/BF - Add support for updated MSP_GPS_CONFIG in API v1.34.0

32e27a3

CF/BF - Disallow CF with API version < v1.34.0.

2540f17

The reason is because the SPRacingF4EVO shipped with cf 1.33.0 (rc1), this forces the user to upgrade and ensures those users don't have a broken experiance.

hydra force-pushed the update-for-api-1.33.0 branch from 0b779ff to 2540f17 Compare April 2, 2017 18:32

hydra removed the Requires testing label Apr 2, 2017

hydra added 2 commits April 7, 2017 21:03

CF/BF - Move welcome icons to theme.

183b7ac

CF/BF - Update for API v0.35.0 - OSD SLAVE.

8a3ca04

hydra force-pushed the update-for-api-1.33.0 branch from 4e20c66 to 8a3ca04 Compare April 8, 2017 20:47

hydra mentioned this pull request Apr 8, 2017

SPRACINGF3OSD for CF V2.0.0 via OSD-SLAVE. cleanflight/cleanflight#2704

Merged

McGiverGim and others added 6 commits April 9, 2017 10:49

Corrections to some BetaFlight references

05af34a

Merge pull request #455 from McGiverGim/correction-references-betafli…

98c85e0

…ght-versions Corrections to some BetaFlight references

CF/BF - Fix failure to reconnect when disconnect occurs with the CLI tab

56d00ec

open.

CF/BF - Prepare for updated OSD Slave boards.

eeb1e39

* Replaces Setup tab with Setup OSD tab for OSD Slave boards - ported from CF v1.x. * Disables CLI tab for OSD Slave boards - due to cleanflight/cleanflight#2710 *

CF/BF - improve readability by reformating the structures.

e3129b4

CF/BF - Disable ESC Sensor and virtual current meter sources for OSD

dfdd9ab

Slave boards.

hydra merged commit ff7478d into master Apr 12, 2017

hydra mentioned this pull request Apr 29, 2017

Multiple IR transponder protocol: How to integrate? betaflight/betaflight#2131

Closed

mikeller mentioned this pull request Jun 4, 2018

Support for SPRACINGOSD betaflight/betaflight#4629

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CF/BF - Update configurator for API 1.33.0. #450

CF/BF - Update configurator for API 1.33.0. #450

hydra commented Mar 19, 2017 •

edited

Loading

hydra commented Mar 19, 2017 •

edited

Loading

mikeller left a comment

mikeller Mar 19, 2017

hydra Mar 20, 2017

mikeller Mar 19, 2017

mikeller Mar 19, 2017

hydra Mar 20, 2017

mikeller Mar 19, 2017

hydra Mar 20, 2017

mikeller Mar 19, 2017

hydra Mar 20, 2017

hydra commented Mar 24, 2017 •

edited

Loading

hydra commented Apr 2, 2017

hydra commented Apr 2, 2017

hydra commented Apr 12, 2017

CF/BF - Update configurator for API 1.33.0. #450

CF/BF - Update configurator for API 1.33.0. #450

Conversation

hydra commented Mar 19, 2017 • edited Loading

hydra commented Mar 19, 2017 • edited Loading

mikeller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hydra commented Mar 24, 2017 • edited Loading

hydra commented Apr 2, 2017

hydra commented Apr 2, 2017

hydra commented Apr 12, 2017

hydra commented Mar 19, 2017 •

edited

Loading

hydra commented Mar 19, 2017 •

edited

Loading

hydra commented Mar 24, 2017 •

edited

Loading