Move to single switch and UI configurable (preparation for PR into homeassistant/core)#117
Closed
basnijholt wants to merge 139 commits into
Closed
Move to single switch and UI configurable (preparation for PR into homeassistant/core)#117basnijholt wants to merge 139 commits into
basnijholt wants to merge 139 commits into
Conversation
Contributor
Author
|
while you're still busy doing awesome work, i noticed you added a I was wondering, is it much work to also add (or change it into) a |
basnijholt
added a commit
to basnijholt/home-assistant
that referenced
this pull request
Dec 19, 2020
The development of this code happened in claytonjn/hass-circadian_lighting#117 With prework done in claytonjn/hass-circadian_lighting#114 and claytonjn/hass-circadian_lighting#107.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Just leaving this here for feedback.
Inspired by #114, I have heavily simplified the setup. Now it's just a single switch that can take all of the settings.
I plan to add this to core soon, as a replacement for Flux.
P.S., don't mind the name switching from Circadian -> Adaptive, I just did a find + replace all to have the original
circadian_lightingand this code side by side in my config.TODO: