Skip to content

Move to single switch and UI configurable (preparation for PR into homeassistant/core)#117

Closed
basnijholt wants to merge 139 commits into
claytonjn:devfrom
basnijholt:as-platform
Closed

Move to single switch and UI configurable (preparation for PR into homeassistant/core)#117
basnijholt wants to merge 139 commits into
claytonjn:devfrom
basnijholt:as-platform

Conversation

@basnijholt

@basnijholt basnijholt commented Sep 12, 2020

Copy link
Copy Markdown
Contributor

Just leaving this here for feedback.

Inspired by #114, I have heavily simplified the setup. Now it's just a single switch that can take all of the settings.

I plan to add this to core soon, as a replacement for Flux.

P.S., don't mind the name switching from Circadian -> Adaptive, I just did a find + replace all to have the original circadian_lighting and this code side by side in my config.

TODO:

  • make it work well with groups
  • set all the correct UI elements
  • integrate the config_validation option parsing
  • respond to events instead of state changes, then don't do anything on HA restart

@basnijholt basnijholt changed the base branch from master to dev September 12, 2020 10:55
@basnijholt

Copy link
Copy Markdown
Contributor Author

This is how the setup looks in the UI:
image

@ChessSpider

ChessSpider commented Sep 12, 2020

Copy link
Copy Markdown

while you're still busy doing awesome work, i noticed you added a sunset_time and sunrise_time. I assume this overrides the sunset/sunrise times for the configured location.

I was wondering, is it much work to also add (or change it into) a min_sunset_time and max_sunrise_time ? So the lights will be on longer if the days are longer, but with long nights it will keep a certain minimum day?

basnijholt added a commit to basnijholt/home-assistant that referenced this pull request Dec 19, 2020
@basnijholt basnijholt closed this Apr 4, 2023
@basnijholt basnijholt deleted the as-platform branch April 4, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants