-
Notifications
You must be signed in to change notification settings - Fork 100
Light profiles #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Light profiles #114
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
65b1aa4
start implementing profile settings, as suggested in https://github.c…
basnijholt eb8da2e
initial implementation of profiles
basnijholt f6219de
another attempt
basnijholt fd1f2fd
add option to add multiple profiles
basnijholt 90cbd29
profiles -> profile
basnijholt db78ab2
setup sensor for default profile
basnijholt 4234be1
fix import
basnijholt 5663a7b
make switch use profile
basnijholt 31da531
fix doc-string
basnijholt 32dea3a
setup a sensor per profile
basnijholt e31915c
switch doesn't need to have the profile as attribute
basnijholt 2eea22b
construct 'today' dict differently
basnijholt 8abab02
Merge branch 'different-today' into light-profile
basnijholt ef444cd
rename _calc_percent
basnijholt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the service_call because I am not sure how to best do it once there are multiple sensors. Also I think it's not really needed. If you want frequent updates, just decease the interval?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how much the service call is used, TBH. Off the top of my head I could imagine it would be useful with the
only_onceoption where a user may want to control exactly when a light adjusts (e.g. any time there's motion).