Fix link when external IP is IPv6 #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external IP module can return an IPv6 address, in which case the method to append a port is to wrap it in square brackets before appending the ":%d" port string. Unfortunately Go's IP module does not have a great way to determine whether an address is an IPv6 address, so fall back to counting the number of colons in the result as suggested in https://stackoverflow.com/a/48519490.
|
Without this patch, the link doesn't work: With this patch, browsers understand what to do: |
|
Good catch! I'll give it a try next week. |
|
LGTM, thanks for taking the time for this. |
claudiodangelis
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external IP module can return an IPv6 address, in which case the method to append a port is to wrap it in square brackets before appending the
:%dport string.Unfortunately Go's IP module does not have a great way to determine whether an address is an IPv6 address, so fall back to counting the number of colons in the result as suggested in https://stackoverflow.com/a/48519490.