-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use spf13/viper for managing the configuration file #254
Use spf13/viper for managing the configuration file #254
Conversation
Adds the Chocolatey package in the list of possibilities to install the Desktop app.
This is a good migration :). However I'd like to see backward compatibility with the JSON. |
Hey @leestarb , thanks for checking in, there will be a function to automatically migrate to YAML at tool startup: https://github.com/claudiodangelis/qrcp/blob/0236150643d4a7358acd0f3ed1bda6853221d882/config/migrate.go |
No, no, no. Such function should change the config file ONLY if the user wants it. Otherwise this should convert it BUT not change the original file, like using converted one that was moved to the temp folder! That is what I suggest :) |
Hello @leestarb , I followed your advise and removed the automatic migration, thanks! |
This PR adds viper configuration management.
Major changes:
QRCP_
prefixI'm still unsure whether or not we should add a function to automatically migrate the old JSON configuration file to YAML.
What is still missing:
migrate
function to transparently migrate to the new YAML configuration file