feat: applications delivery menu redirection link #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometherion
requested changes
Feb 27, 2025
.env.example
Outdated
| # Base Path where to deploy the UI | ||
| NEXT_PUBLIC_BASE_PATH=/ | ||
| #NEXT_PUBLIC_BASE_PATH=/ |
There was a problem hiding this comment.
Why this has been commented?
There was a problem hiding this comment.
Because otherwise doesn't work on localhost. I will remove the comment on .env.example
.gitignore
Outdated
Comment on lines
44
to
47
|
|
||
| #package-lock.json | ||
| package-lock.json | ||
|
|
There was a problem hiding this comment.
AFAIK, the lock file must be committed to ensure reproducibility builds based on SHA.
src/app/auth/signin/page.tsx
Outdated
| @@ -104,6 +104,7 @@ const SignInWithCredentials = () => { | |||
| }} | |||
| > | |||
| {({ handleSubmit, dirtySinceLastSubmit, submitErrors, submitting }) => { | |||
| console.log("submit errors:" , submitErrors) | |||
There was a problem hiding this comment.
Let's clean console.log debug information unless we use a logger with a configurable verbosity level.
src/auth/server/auth.service.ts
Outdated
| @@ -58,6 +58,7 @@ export class Auth { | |||
| } | |||
|
|
|||
| async login(input: LoginInput) { | |||
| console.log("Entered login: ", input) | |||
There was a problem hiding this comment.
Same as above: no debug messages.
| if(token) | ||
| return `${process.env.NEXT_PUBLIC_SVELTOS_URL}/sveltos/clusters?auth=${encodeURIComponent(token)}`; | ||
|
|
||
| return '' |
There was a problem hiding this comment.
Can we disable the Sveltos Addon menu item in case of a missing token?
src/constants/constants.ts
Outdated
| @@ -0,0 +1,2 @@ | |||
| export const RedirectUrlSveltosKey = 'Sveltos' | |||
| export const RedirectUrlGrafanaKey = 'Grafana' | |||
There was a problem hiding this comment.
Missing new line at the end of the file.
prometherion
changed the title
prometherion
requested changes
Feb 28, 2025
prometherion
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.