-
Notifications
You must be signed in to change notification settings - Fork 0
add root book as a landing page #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your PR! A preview of your changes is live at |
This currently runs: mdbook build
mkdir -p public/pr
cp CNAME public/
cp robots.txt public/
mkdir -p public
git fetch --depth=1 origin +gh-pages:refs/remotes/origin/gh-pages
git archive --prefix=public/ refs/remotes/origin/gh-pages -- ':(glob)pr-*/**' | tar x || true So:
I think the If you don't like that, please just do mdbook build
mkdir -p public
cp CNAME public/
cp robots.txt public/
git fetch --depth=1 origin +gh-pages:refs/remotes/origin/gh-pages
git archive --prefix=public/ refs/remotes/origin/gh-pages -- ':(glob)pr-*/**' | tar x || true because it's a bit much :-D. Note that there's another issue with that code, see message below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to adjust the glob for git archive
Thanks for going forward with this! |
Thanks for the review! I kept the |
8920186
to
e888c0f
Compare
cleaned up the directory creation even more! Should be good now? |
Do you mind if I squash the latest commit into the "add root book" commit? I like clean histories :-D |
No no, go ahead if you want to do it :) |
e888c0f
to
a9ce42f
Compare
This also adds a
robots.txt
so that PR previews don't get indexed by search engines.Also deduplicates the theme in the repository using symlinks. They will still be duplicated once deployed, but that should be okay.