Skip to content

Drop support for GHC 8.6 and 8.8 #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martijnbastiaan merged 1 commit into from
Feb 13, 2024
Merged

Drop support for GHC 8.6 and 8.8 #2664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/docker/build-and-publish-docker-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ elif [[ "$1" != "" ]]; then
exit 1
fi

GHC_VERSIONS=( "9.6.2" "9.4.6" "9.2.8" "9.0.2" "8.10.7" "8.8.4" "8.6.5")
CABAL_VERSIONS=("3.10.1.0" "3.8.1.0" "3.6.2.0" "3.4.0.0" "3.2.0.0" "3.2.0.0" "3.0.0.0")
GHC_VERSIONS=( "9.6.2" "9.4.6" "9.2.8" "9.0.2" "8.10.7")
CABAL_VERSIONS=("3.10.1.0" "3.8.1.0" "3.6.2.0" "3.4.0.0" "3.2.0.0")

# We want to use docker buildkit so that our layers are built in parallel. This
# is ignored completely on versions of docker which don't support buildkit.
Expand Down
34 changes: 0 additions & 34 deletions .ci/stack-8.6.yaml
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions .ci/stack-8.8.yaml
View file
Open in desktop

This file was deleted.

11 changes: 3 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,12 @@ jobs:
fail-fast: false
matrix:
os: ["macOS", "windows"]
ghc: ["8.6", "8.8", "8.10", "9.0", "9.2", "9.4"]
ghc: ["8.10", "9.0", "9.2", "9.4"]
exclude:
# Some tests fail with a mysterious -11 error code.
- os: macOS
ghc: 8.10

# Windows gets non-deterministically gets stuck in infinite loops
# or segfaults while running the testcase.
- os: windows
ghc: 8.8

# GHC 9.0 fails to compile clash-cores due to a template haskell
# failure
- os: windows
Expand Down Expand Up @@ -115,11 +110,11 @@ jobs:
strategy:
fail-fast: false
matrix:
ghc: [ "8.6.5", "9.0.2", "9.6.2" ]
ghc: [ "8.10.7", "9.0.2", "9.6.2" ]
include:
- multiple_hidden: yes

- ghc: 8.6.5
- ghc: 8.10.7
multiple_hidden: no
workaround_ghc_mmap_crash: yes

Expand Down
6 changes: 1 addition & 5 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,7 @@ tests:
WORKAROUND_GHC_MMAP_CRASH: "yes"
RUN_TESTS: "always"

- GHC_VERSION: [8.10.7, 8.8.4]
WORKAROUND_GHC_MMAP_CRASH: "yes"
RUN_TESTS: "nightly"

- GHC_VERSION: 8.6.5
- GHC_VERSION: [8.10.7]
WORKAROUND_GHC_MMAP_CRASH: "yes"
MULTIPLE_HIDDEN: "no"
RUN_TESTS: "always"
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ Note that release branches might contain non-released patches.
## GHC compatibility
| | Linux | Windows | macOS | Clash (released) | Clash (development version)
|------|-------|---------|-------|------------------|--------------------------
| 8.6 | ✔️ | ✔️ | ✔️ | 1.0 - 1.6 | ✔️
| 8.8 | ✔️ | ❌ | ✔️ | 1.0 - 1.6 | ✔️
| 8.6 | ✔️ | ✔️ | ✔️ | 1.0 - 1.6 | ❌ ️
| 8.8 | ✔️ | ❌ | ✔️ | 1.0 - 1.6 | ❌ ️
| 8.10 | ✔️ | ✔️ | ❌ | 1.2 - 1.6 | ✔️
| 9.0 | ✔️ | ✔️² | ✔️ | 1.4 - 1.6 | ✔️
| 9.2 | ⚠️¹ | ⚠️¹ | ⚠️¹ | | ⚠️¹️
Expand Down
1 change: 1 addition & 0 deletions changelog/2024-02-11T11_14_33+01_00_drop_support_for_ghc86_ghc88
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
REMOVED: Clash no longer supports GHC 8.6 and GHC 8.8
17 changes: 5 additions & 12 deletions clash-ghc/clash-ghc.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ library
HS-Source-Dirs: src-bin-9.0
elif impl(ghc >= 8.10.0)
HS-Source-Dirs: src-bin-8.10
elif impl(ghc >= 8.8.0)
HS-Source-Dirs: src-bin-881
elif impl(ghc >= 8.6.0)
HS-Source-Dirs: src-bin-861

GHC-Options: -Wall -Wcompat
if impl(ghc >= 8.10.0)
Expand Down Expand Up @@ -176,9 +172,9 @@ library
ghc-typelits-natnormalise >= 0.6 && < 0.8,
deepseq >= 1.3.0.2 && < 1.6,
time >= 1.4.0.1 && < 1.14,
ghc-boot >= 8.6.0 && < 9.9,
ghc-boot >= 8.10.0 && < 9.9,
ghc-prim >= 0.3.1.0 && < 0.12,
ghci >= 8.6.0 && < 9.9,
ghci >= 8.10.0 && < 9.9,
uniplate >= 1.6.12 && < 1.8,
reflection >= 2.1.2 && < 3.0,
primitive >= 0.5.0.1 && < 1.0,
Expand All @@ -187,15 +183,12 @@ library
utf8-string >= 1.0.0.0 && < 1.1.0.0,
vector >= 0.11 && < 1.0

if os(windows)
-- 8.8 is broken on Windows - it randomly segfaults
Build-Depends: ghc >= 8.6.0 && < 8.8.0 || >= 8.10.0 && < 9.9
elif os(darwin)
if os(darwin)
-- 8.10 is broken on macOS - it exits tests with status code -11
Build-Depends: ghc >= 8.6.0 && < 8.10.0 || >= 9.0.0 && < 9.9
Build-Depends: ghc >= 9.0.0 && < 9.9
else
-- Unix
Build-Depends: ghc >= 8.6.0 && < 9.9
Build-Depends: ghc >= 8.10.0 && < 9.9

if impl(ghc >= 8.10.0)
Build-Depends: exceptions >= 0.10.4 && < 0.11,
Expand Down
61 changes: 0 additions & 61 deletions clash-ghc/src-bin-861/Clash/GHCi/Leak.hs
View file
Open in desktop

This file was deleted.

Loading