-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print previous errors if local module fails to load #2663
Conversation
:: Monad m | ||
=> String | ||
-> Data.Text.Text | ||
-> (t -> r) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: there's a slight refactor in here. I've removed the (t -> r)
argument. Is now handled by the caller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo simple comment
d80e44c
to
5764486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5764486
to
7abc72e
Compare
7abc72e
to
f5ffc1a
Compare
Fixes #2365 (cherry picked from commit 2b76b07) Co-authored-by: Martijn Bastiaan <[email protected]>
Fixes #2365
Example of a new-style error message:
Instead of the old:
Still TODO: