Fixes #41: Don’t panic on invalid comparisons. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #41 |
Signed-off-by: Hiram Chirino <[email protected]>
|
The PartialEq implementation looks good, but I'm thinking that we actually want to return a None on the PartialOrd implementation. I need to check the spec again and see. By using the type ids, we'd be following an ordering scheme that's not strictly defined in the spec, so I'd prefer to return None which triggers a comparison error. As a note, there are currently a few other places where we have panics, which you can see by searching for unreachable!. Agreed that nothing should panic. |
clarkmcc
requested changes
Jun 6, 2024
|
None it is. |
Co-authored-by: Clark McCauley <[email protected]> Signed-off-by: Hiram Chirino <[email protected]>
clarkmcc
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.