Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intersects: Possible false negative if test geometry is multi-polygon #31

Closed
clarisma opened this issue Jan 4, 2024 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@clarisma
Copy link
Owner

clarisma commented Jan 4, 2024

Verify that intersects filter correctly identifies this situation:

  • Test geometry is a multi-polygon
  • Candidate geometry is polygonal, does not lie inside test MP, does not cross the linework of the test MP, but does contain one of the MP's polygons.
  • Current check relies on representative point, which is insufficient
    • Also performs check only if candidate bbox contains test bbox; this works if test geom is a single polygon, but will not be sufficient for MP
@clarisma clarisma added todo A feature that has been specified, but not yet implemented bug Something isn't working and removed todo A feature that has been specified, but not yet implemented labels Jan 4, 2024
clarisma added a commit that referenced this issue Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant