-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update for webservices at CLST, Radboud University, Nijmegen (auto-harvested) #61
Conversation
…tion, Grapheme to Phoneme Conversion, Transliteration, Text Normalisation, Optical Character Recognition, Handwritten Text Recognition (all of these are motivated by actual services we have in these categories)
…LAM webservices at CLST, Nijmegen and converts them to (numerous!) switchboard registry entries
…ed ones (may have different names), some are dismantled anyway
…d by the clam2switchboard harvester)
@proycon json validation fails, do you have access to travis? (https://travis-ci.org/github/clarin-eric/switchboard-tool-registry/builds/731614143). Most of the errors are missing logos (must be a string). You can also run the validation yourself, see the command in the travis file: https://github.com/clarin-eric/switchboard-tool-registry/blob/master/.travis.yml |
Thanks, I see it now yes! I'll prepare a fix |
The validation now passes successfully. |
Before merging this to production, I tried to check https://beta-switchboard.clarin.eu/ and https://switchboard.clarin-dev.eu/switchboard-test/ to test-drive these changes. But it seems they are not available. Is this correct or did I overlook something? |
@proycon Could you add a logo image for these tools? Otherwise they will be displayed with a missing logo: https://beta-switchboard.clarin.eu/tools |
Good point, I'll send a new PR with some logo images soon. |
It seems some of the logos that are already present are not being shown? Like frog.jpg , might this be a bug? Or do they necessarily have to pngs now? |
Most image files are supported, an entry of |
That's what I thought yes, but for example the frog logo doesn't show on https://beta-switchboard.clarin.eu/tools even though the API call works. |
I don't see any tools that have this logo in the json file, am I missing something? |
Hmm, indeed, I guess I was looking in another git branch. I see now that they are missing from this PR. |
FTR: I have been and am test-driving the CLAM services and once the last glitches are resolved (I'm communicating with proycon about this) this PR can be merged. I'll give an update in this thread. |
To merge this in |
I am removing it to be able to merge the metadata part to |
@proycon We decided it would be better to store all contrib code in a separate repository, something like |
@emanueldima That sounds like a good solution yes! If you create the repo then I'll gladly push my harvest script there. |
This PR updates the tool registry for our CLAM-based webservices. There are some major changes:
contrib/harvest
directory (I imagine it could hold various kinds of user contributed harvesting scripts). This means you can update the tool metadata even without my intervention, by just running the script.An extra round of testing is still required to ensure that all these all work properly. I remember you guys have nice automated systems for that right?