Audit Issue 25: Use ExternalConsensusLocationsConverterFor in Inbound Queue v2#19
Merged
claravanstaden merged 2 commits intosnowbridge-v2-audit-fixesfrom Apr 14, 2025
Merged
Conversation
vgeddes
reviewed
Apr 11, 2025
| EthereumUniversalLocation, | ||
| GlobalAssetHubLocation, | ||
| AssetHubUniversalLocation, | ||
| AccountId, |
There was a problem hiding this comment.
Seems unused since you're configuring ExternalConsensusLocationsConverterFor to directly convert to [u8; 32].
Suggested change
| AccountId, |
|
Review required! Latest push from author must always be reviewed |
vgeddes
approved these changes
Apr 14, 2025
claravanstaden
merged commit e4894f6
into
snowbridge-v2-audit-fixes
114 of 210 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-1478