fix: Prefer $XDG_CONFIG_HOME to $HOME/.config on Linux - #215
Merged
Conversation
claration
approved these changes
Jul 2, 2026
Owner
|
Thank you! I'm not very well versed in linux so I was never sure if using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flatpak apps should store config to
$XDG_CONFIG_HOMEaccording to Flatpak docs.Current implementation uses
$HOME/.config, which is on tmpfs in Flatpak by default if no host directory access is granted (according to Flatpak docs). Such in the case, PlumeImpactor would lost config after restart.Use
$XDG_CONFIG_HOME, which is persistent in Flatpak sandboxes, fall back to$HOME/.configif the former does not exist.Fixes: #153
A quick fix for current Flatpak users is
flatpak override --user --persist=.config dev.khcrysalis.PlumeImpactor, which maps.var/app/dev.khcrysalis.PlumeImpactor/.configto$HOME/.configso to make it persistent.