fix: Don't treat default env vals as explicit#6211
Closed
charliermarsh wants to merge 1 commit intoclap-rs:masterfrom
Closed
fix: Don't treat default env vals as explicit#6211charliermarsh wants to merge 1 commit intoclap-rs:masterfrom
charliermarsh wants to merge 1 commit intoclap-rs:masterfrom
Conversation
1e058f2 to
2d721f6
Compare
Member
|
@charliermarsh I appreciate the interest in moving this forward but this is not a change to be made lightly and the way forward is design discussions on the issue and not a PR, per our contrib guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We frequently see user reports in uv (e.g., astral-sh/uv#13385) related to the fact that environment variables set to fasely values still report as conflicting. Here's a minimal example from #5591 (comment):
This PR modifies the parsing to treat "set from environment" behavior as non-explicit if the value matches the default.
Closes #5591.