Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(derive): Improve build times #4777

Merged
merged 2 commits into from
Mar 23, 2023
Merged

perf(derive): Improve build times #4777

merged 2 commits into from
Mar 23, 2023

Conversation

epage
Copy link
Member

@epage epage commented Mar 23, 2023

The more widely available improvement is the dropping of proc-macro-error. This dependency was less than ideal because it itself was a proc macro, further serializing our builds (requiring all proc macro machiner to be built before proc-macro-error before clap_derive). Now, we don't just have fewer dependencies but hopefully more parallelism.

This unblock the second almost as widely scoped improvement: upgrading to syn v2. proc-macro-error was on syn v1 and it hadn't been touched in a while, so I wasn't confident in a timely upgrade (plus I've been wanting to drop it anyways, see above). Now, it'll be easier to only have one version of syn in the dependency tree (as of 5 days ago, 39.3% of all crates depended on syn v2 already)

Made things simpler that we were always aborting before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant