Add env feature gate #2694
Merged
Add env feature gate #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
approved these changes
Aug 14, 2021
There was a problem hiding this comment.
I'm making the assumption that we see no reason for someone to determine this at runtime.
I dislike the number of conditionals this requires though. I prefer to limit my conditionals to where I have a nice cut off point / can use a null module so knowledge of the feature doesn't leak everywhere. It complicates the code and makes it more likely that some untest combination of flags will fail..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at Kevin's recent changes in the
modularbranch and since we haveDisableEnvsetting, I felt like this is a better way to do it.