Closed
Conversation
- This makes it so `doc` compiles on stable - We keep the ugly lifetime hack, just make clippy be quiet about it Fixes clap-rs#2618
2 tasks
It looks like CI hasn't been running on this and we've introduced some problems. It looks like we had an off-by-one error in the check for MSRV for deciding to run ui tests.
Member
|
I couldn't push to this PR. So, had to create #2645 which supersedes this. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides subtle output changes in Rust, we had some ui tests failing because some issues slipped through CI. It looks like we had an off-by-one error causing it to be ignored on our MSRV runs. This is addressed in a separate commit within this PR.
I tried making it so the README is always pulled in, since that can work on our MSRV, but that breaks the no-feature CI run (examples use
clap_derive). So instead I addeddocto the CI to make sure the README is tested.Fixes #2618