Allow for nested subcommands with ZSH generation.#2100
Merged
bors[bot] merged 1 commit intoclap-rs:masterfrom Aug 24, 2020
Merged
Allow for nested subcommands with ZSH generation.#2100bors[bot] merged 1 commit intoclap-rs:masterfrom
bors[bot] merged 1 commit intoclap-rs:masterfrom
Conversation
pksunkara
requested changes
Aug 23, 2020
Member
pksunkara
left a comment
pksunkara
left a comment
There was a problem hiding this comment.
Please add a test. I am not sure the logic is correct, but let's see.
Contributor
Author
Done! Here's a link to a asciinema of the content of that test in action: https://asciinema.org/a/vdLVvh13ypq0AKERZHWiu8otb
Yeah this one is difficult since the behavior of I think I captured the original intent though; I think the function is supposed to return the last parser in a chain of sub-commands, but there was no recursion to allow for multiple levels of sub-commands. |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2098