Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing breaking change in changelog or invalid feature for clap_app! ? #402

Closed
Keats opened this issue Jan 29, 2016 · 3 comments · Fixed by #404
Closed

Missing breaking change in changelog or invalid feature for clap_app! ? #402

Keats opened this issue Jan 29, 2016 · 3 comments · Fixed by #404
Assignees
@kbknapp
Labels
A-docs Area: documentation, including docs.rs, readme, examples, etc...

Comments

@Keats
Copy link
Contributor

Keats commented Jan 29, 2016

Posted it on reddit but figured it might be a better place:

Tried to update https://github.com/Keats/dbmigrate to clap 2.0 but realised the unstable feature requires nightly rust since its feature flag includes clippy.
Maybe it should be mentioned that the clap_app macro is not usable anymore outside of the nightly branch in the breaking changes? What's the reasoning behind it?

I can update the changelog/change feature set depending on whether that was intentional or not
@kbknapp
Copy link
Member

kbknapp commented Jan 30, 2016

#403 Fixes this. Apologies for missing it!

kbknapp added a commit that referenced this issue Jan 30, 2016
@kbknapp
fix: fixes cargo features to NOT require nightly with unstable features
dcbcc60 
Closes #402
@kbknapp kbknapp added P1: urgent A-docs Area: documentation, including docs.rs, readme, examples, etc... labels Jan 30, 2016
@kbknapp kbknapp self-assigned this Jan 30, 2016
@homu homu closed this as completed in 280ada7 Jan 30, 2016
@Keats
Copy link
Contributor Author

Keats commented Jan 30, 2016

Cheers, is #252 the place for the macro changes or is it somewhere else?

@kbknapp
Copy link
Member

kbknapp commented Jan 30, 2016

For subscription to changes yes. We may spawn some issues based off that one, but all discussion should start there. Also note, the changes I'm thinking of are kind of low on the priority chart right now, so don't expect pre-1.0 Rust level breaking changes 😉

@Keats Keats mentioned this issue Jan 30, 2016
Merged
homu added a commit that referenced this issue Jan 30, 2016
@homu
Auto merge of #404 - Keats:fix-macro, r=Vinatorul
0fe87dd 
fix: clap_app! should be gated by unstable, not nightly feature

Should fix #402
homu added a commit that referenced this issue Jan 30, 2016
@homu
Auto merge of #404 - Keats:fix-macro, r=Vinatorul
f50b8db 
fix: clap_app! should be gated by unstable, not nightly feature

Should fix #402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbknapp kbknapp

Labels
A-docs Area: documentation, including docs.rs, readme, examples, etc...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clap_app! should be gated by unstable, not nightly feature Keats/clap-rs
2 participants
@Keats @kbknapp