Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Macro API #2835

Closed
epage opened this issue Oct 9, 2021 · 5 comments · Fixed by #2848
Closed

Deprecate Macro API #2835

epage opened this issue Oct 9, 2021 · 5 comments · Fixed by #2848
Milestone
3.0

Comments

@epage
Copy link
Member

epage commented Oct 9, 2021

The Macro API was meant to be a performant, ergonomic version of the builder API. However, there is a level of technical load in keeping it around and sufficiently documented and seems to mostly go unused.

Let's deprecate it for 3.0 and either spin it off into a standalone crate or remote it completely in a followup version.
@epage epage added this to the 3.0 milestone Oct 9, 2021
@pksunkara pksunkara mentioned this issue Oct 9, 2021
Open
2 tasks
epage added a commit to epage/clap that referenced this issue Oct 11, 2021
@epage
fix: Deprecate Macro API
e90c30c 
Fixes clap-rs#2835
@epage epage mentioned this issue Oct 11, 2021
Merged
epage added a commit to epage/clap that referenced this issue Oct 11, 2021
@epage
fix: Deprecate Macro API
51274f8 
Fixes clap-rs#2835
@bors bors bot closed this as completed in 0a53faf Oct 12, 2021
@epage
Copy link
Member Author

epage commented Dec 8, 2021

If users decide to fork clap_app and continue its development, some relevant commits

@UltiRequiem
Copy link

keeping it around and sufficiently documented and seems to mostly go unused.

I really like it and I was using it in most of my projects 😭

@epage
Copy link
Member Author

epage commented Apr 5, 2022

I did say "mostly" :)

You are welcome to split it out into a separate crate!

@UltiRequiem
Copy link

I did say "mostly" :)

You are welcome to split it out into a separate crate!

I'm updating them to use the Derivate API, which is cool too.

Thanks for the hard work!

@Peefy Peefy mentioned this issue Dec 12, 2022
Closed
@bergkvist
Copy link

I miss the clap_app! macro as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

fix: Deprecate Macro API epage/clap
3 participants
@epage @bergkvist @UltiRequiem