Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seedarg/global/wip #26

Merged
merged 36 commits into from
Feb 26, 2019
Merged

Seedarg/global/wip #26

merged 36 commits into from
Feb 26, 2019

Conversation

jcantrell
Copy link

@jcantrell jcantrell commented Feb 26, 2019 •
edited by connorkuehl
Loading

Closes #9

Jordan Cantrell and others added 30 commits February 21, 2019 19:09
putting RandstructSeed in Decl.h
11d18d7
remove RandstructSeed declaration from Decl.h
3deff88
value not being saved in global
162bda5
removing unused coede
97bb5ce
removing randstruct constructor call
6ef63eb
test commit
b3a2306
printf debugging
a9200c2
manually adding arg before executing
5ceee39
adding include to job.cpp
5dd2a45
throwaway commit
76f2bd1
more printf debugging
c4863cc
even more printf debugging
1dbbe31
added frandstruct-seed= to CC1Options.td
d1d871c
added frandstruct-seed= to CC1Options.td
efa2157
removing =
7a329b5
removing =
495b157
error: linker -f may not be used without -shared
651fdc4
error: linker -f may not be used without -shared
013a77d
error: linker -f may not be used without -shared
184695d
gen. commit
0594d7e
wip fixing linker errors
3656e01
wip fixing linker errors
f07aff2
wip fixing linker errors
213041f
wip fixing linker errors
ab0393f
wip fixing linker errors
d923c6f
wip fixing linker errors
25246d2
wip fixing linker errors
1455704
wip fixing linker errors
3dcf748
generic commit
46b491e
generic commit
d149823
nforbus
nforbus previously approved these changes Feb 26, 2019
View reviewed changes
Copy link

@nforbus nforbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and it works. Order was;

git fetch
git checkout seedarg/global/wip
git pull (up to date)
cd build -> make
git clone https://github.com/clang-randstruct/testing.git
cd testing
clang poc.c
./reg
./rand

Randomization is working as expected.

tim-pugh
tim-pugh reviewed Feb 26, 2019
View reviewed changes
Copy link
Member

@tim-pugh tim-pugh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It compiles!

I tested the frandstruct -> randstruct changes and it compiled.

jeffreytakahashi
jeffreytakahashi approved these changes Feb 26, 2019
View reviewed changes
Copy link

@jeffreytakahashi jeffreytakahashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this and tested it and it looks solid, working as intended.

tim-pugh
tim-pugh approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@tim-pugh tim-pugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except frandstruct :)

@tim-pugh tim-pugh merged commit f5e549d into clang-randstruct:develop Feb 26, 2019
@tim-pugh tim-pugh mentioned this pull request Feb 26, 2019
Closed
connorkuehl
connorkuehl reviewed Feb 26, 2019
View reviewed changes
Copy link

@connorkuehl connorkuehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places where we aren't using the data member random seed engine. We should only seed once (on object creation) and re-use that same engine each time.

clang/lib/AST/RecordFieldReorganizer.cpp
@@ -95,7 +97,8 @@ const size_t CACHE_LINE = 64;

SmallVector<FieldDecl *, 64> Bucket::randomize() {
// FIXME use seed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this comment.

clang/lib/AST/RecordFieldReorganizer.cpp
@@ -95,7 +97,8 @@ const size_t CACHE_LINE = 64;

SmallVector<FieldDecl *, 64> Bucket::randomize() {
// FIXME use seed
auto rng = std::default_random_engine{};
std::seed_seq Seq(RandstructSeed.begin(), RandstructSeed.end());
auto rng = std::default_random_engine{Seq};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this local seed engine and use the data member rng

clang/lib/AST/RecordFieldReorganizer.cpp
auto rng = std::default_random_engine{};
SmallVector<Decl *, 64> Randstruct::randomize(SmallVector<Decl *, 64> fields) {
std::seed_seq Seq(RandstructSeed.begin(), RandstructSeed.end());
auto rng = std::default_random_engine{Seq};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this local seed engine and use the data member rng

clang/lib/AST/RecordFieldReorganizer.cpp
@@ -231,7 +237,8 @@ SmallVector<Decl *, 64> perfrandomize(const ASTContext &ctx,
buckets.push_back(std::move(currentBitfieldRun));
}

auto rng = std::default_random_engine{};
std::seed_seq Seq(RandstructSeed.begin(), RandstructSeed.end());
auto rng = std::default_random_engine{Seq};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this seed engine and use the data member rng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorkuehl connorkuehl connorkuehl left review comments

@tim-pugh tim-pugh tim-pugh approved these changes

@Jafosterja Jafosterja Awaiting requested review from Jafosterja

@jeffreytakahashi jeffreytakahashi Awaiting requested review from jeffreytakahashi

@nforbus nforbus Awaiting requested review from nforbus

@Nixoncole Nixoncole Awaiting requested review from Nixoncole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcantrell @connorkuehl @tim-pugh @nforbus @jeffreytakahashi