-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program hangs when launching Chromium process #164
Comments
Can you set |
@claabs Sadly no more information with log level trace, but the line with testing all configured notifiers is printed twice
|
Alright, this is gonna be ugly, but can you add the environment variable: |
Oh it wasn't that bad I sent you an email with the logs, I think I redacted all the information but wasn't sure when there was session ID's and similar. |
I'm a little stumped. It seems it's just stuck on What host OS are you using? It works fine for me in WSL2 and Unraid. |
@claabs I am using unraid |
Can you post your config with the sensitive stuff redacted? |
@claabs Here is the command generated by unraids dockerman root@localhost:# /usr/local/emhttp/plugins/dynamix.docker.manager/scripts/docker run -d --name='epicgames-freegames' --net='bridge' -e TZ="Europe/Berlin" -e HOST_OS="Unraid" -e 'TZ'='Europe/Oslo' -p '3000:3000/tcp' -v '/mnt/user/appdata/epicgames-freegames/':'/usr/app/config':'rw' 'charlocharlie/epicgames-freegames:latest' {
"searchStrategy": "promotion",
"runOnStartup": true,
"cronSchedule": "8 17 * * *",
"logLevel": "trace",
"testNotifiers": true,
"hcaptchaAccessibilityUrl": "https://accounts.hcaptcha.com/verify_email/REDACTED",
"webPortalConfig": {
"baseUrl": "REDACTED"
},
"accounts": [
{
"email": "REDACTED",
"password": "REDACTED",
"totp": "REDACTED"
}
],
"notifiers": [
{
"type": "discord",
"webhookUrl": "https://discord.com/api/webhooks/REDACTED/REDACTED"
}
]
} |
I have a few ideas that I'm just jotting down so I can try out later:
|
I don't think the Chromium version was the issue, as it was already using the correct version. These docs from puppeteer recommended the I'm still not able to recreate this on my systems, so please try again when available. |
Issue #166 is still persisting for me ( For shits and giggles I checked with Edit: Actually, after a few restarts it seems to have moved past Edit2: A few more restarts and everything seems to just work now? I changed virtually nothing in the config except toggling Edit3: I have no idea what's going on, I am back to not being able to run test notifications. Apologies for all the edits. Edit4: I'm at a loss. It did properly go through the ordering of the three available games, then I restarted to correct an issue with the URL I provided for the notification and... it just stalls again. It almost feels like a race condition. |
The puppeteer docs recommend adding Yeah it's either a race condition or memory related. I'm just surprised I've never run into it myself. |
Took me a bit to test this, but no change with that flag set. |
I published a Debian version of the image to my test tag: Feel free to test it for consistency. If it fixes your issue, I'll publish it to the project's official images. |
I'm seeing that image work immediately and consistently, but I can't be sure it isn't "just working" as before. Would likely be a good idea to have @sigboe confirm. |
I think this is the same as the various issues mentioned in this puppeteer PR fix: puppeteer/puppeteer#7802 Although Alpine doesn't have Chromium 97 that puppeteer 13.0.0 uses, I think Chromium 96 should work okay. At the very least, it's better than Chromium 93 we were using previously. |
Scratch that, Chromium 96 doesn't run in Alpine 3.14. We'll have to wait a few days until the Node 3.15 image releases. However puppeteer 13.0.0 still seems to operate in Chromium 93, so maybe it will still be resolved. |
I added a fix that will retry launching the browser until it actually works. It's kind of a memory risk as it doesn't actually close the failed launched Chromium process (more here). In my personal testing, I've only seen it retry once, so it sees double the memory usage for the duration of the process. I'd have to track the process ID of the failed launch, which is kind of tricky. I'll have to dig into it later. |
I don't think I have had the this problem this whole year |
Describe the bug
I enabled the notification feature in the json file, and I updated/restarted the container.
The log stops at
Testing all configured notifiers
and doesn't continue. I do not get a notification, I do not know if it is working, I assume its working. When I disable the test notification in the json the log continues through and checks for free games successfully, and starts the cron job.Screenshots or Logs
Log when the test is enabled.
Log when the test is disabled (set to false)
The text was updated successfully, but these errors were encountered: