Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Touch Hack" for clippy when Rust v1.52 is here #119

Closed
ChristianMoesl opened this issue Mar 10, 2021 · 2 comments · Fixed by #134
Closed

Remove "Touch Hack" for clippy when Rust v1.52 is here #119

ChristianMoesl opened this issue Mar 10, 2021 · 2 comments · Fixed by #134
Labels
build Build and CI Pipeline released

Comments

@ChristianMoesl
Copy link
Collaborator

ChristianMoesl commented Mar 10, 2021 •
edited
Loading

We use a hack to ensure, that cargo clippy actually runs on all of the source in .cargo-husky/hooks/pre-commit. This is now fixed (rust-lang/rust-clippy#4612) and can therefore be removed once the fix lands in Rust stable (~v1.52).
@ChristianMoesl ChristianMoesl added the build Build and CI Pipeline label Mar 10, 2021
ChristianMoesl added a commit that referenced this issue May 7, 2021
@ChristianMoesl
chore: update Rust toolchain to v1.52.0 (#119)
3f2cc9d 
fixes #119
@ChristianMoesl ChristianMoesl mentioned this issue May 7, 2021
Merged
@mstarzinger
Copy link
Collaborator

👏

ChristianMoesl added a commit that referenced this issue May 10, 2021
@ChristianMoesl
chore: update Rust toolchain to v1.52.0 (#119)
0aa2190 
fixes #119
@github-actions
Copy link

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Build and CI Pipeline released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update Rust toolchain to v1.52.0 (#119) cksystemsgroup/monster
2 participants
@mstarzinger @ChristianMoesl