Handle string function names

lib/ex_factor/neighbors.ex

@@ -8,7 +8,13 @@ defmodule ExFactor.Neighbors do
   Find all the instances of the target function. Return after evaluating all the block-level
   AST elements. Ignore certain elements, such as :alias.
   """
-  def walk(block, fn_name, arity \\ :unmatched) do
+  def walk(block, fn_name, arity \\ :unmatched)
+  def walk(block, fn_name, arity) when is_binary(fn_name) do
+    # fn_name_atom = String.to_atom(fn_name)
+    walk(block, String.to_atom(fn_name), arity)
+  end
+
+  def walk(block, fn_name, arity) do
     block
     |> Enum.reduce({[], []}, fn el, acc ->
       eval_elem(el, acc, fn_name, arity)

test/ex_factor/extractor_test.exs

@@ -25,6 +25,9 @@ defmodule ExFactor.ExtractorTest do
       end
     end
 
+    test "noop when no matching fns found in source" do
+    end
+
     test "write a new file with the function" do
       content = """
       defmodule ExFactorSampleModule do

test/ex_factor/neighbors_test.exs

@@ -56,6 +56,31 @@ defmodule ExFactor.NeighborsTest do
              ] = Neighbors.walk(block, :pub1)
     end
 
+    test "it finds the target when the last function and function is a string" do
+      module =
+        """
+        defmodule ExFactorSampleModule do
+          def pub1(arg1) do
+            :ok
+          end
+          _docp = "arbitrary module-level elem"
+          defp priv1(arg1) do
+            :ok
+          end
+          def pub2(arg2) do
+            :ok
+          end
+        end
+        """
+        |> Code.string_to_quoted()
+
+      {_ast, block} = Parser.block_contents(module)
+
+      assert [
+               {:def, _, [{:pub2, _, [{:arg2, _, nil}]}, _]}
+             ] = Neighbors.walk(block, "pub2")
+    end
+
     test "it should handle ignore the aliases" do
       module =
         """