#7330 Editing part for the linking images feature #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
suggested changes
Jun 9, 2020
|
@jodator, I applied your suggestion. Ready for review once again. |
jodator
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (link): Introduced the editing part of linking images feature. Closes #7330.
Other (image):
image/image/utils~getViewImgFromWidget()will look for nested<img>element in the widget.☝️ I'm not sure it's worth mentioning.
Since the PR introduced only a part of the entire plugin (we're still missing UI and Docs), I'd suggest reviewing this code and make it as a base for other parts. New branches will be merged to this one and after finishing the entire plugin, we will be able to merge full stuff to the master.
CI: https://travis-ci.org/github/ckeditor/ckeditor5/builds/694996103