Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added performance manual tests #6176

Merged
merged 23 commits into from
Feb 6, 2020
Merged

Added performance manual tests #6176

merged 23 commits into from
Feb 6, 2020

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Feb 3, 2020

Suggested merge commit message (convention)

Type: Added performance manual tests. Closes #5880.


Additional information

I'm pretty positive that we should disable the CKE5 inspector for these tests, as it has a noticeable impact on the results, while it is not relevant for CKEditor 5 end user. But I'd like to clarify this before I implement this.

Other notes:

  • The fixtures are shared across the tests.
  • The editors with the exception of rich editor use the same feature preset.

In the end we decided to do this task in a single pull request, rather than series of micro PRs, so there are a few changes;

$ git diff --stat master
 tests/_data/full-websites-styled.html         | 5254 +++++++++++++++++++
 tests/_data/large.html                        | 6718 +++++++++++++++++++++++++
 tests/_data/medium.html                       | 1535 ++++++
 tests/_data/small-inline-css.html             |  347 ++
 tests/_data/small.html                        |   18 +
 tests/_utils/utils.js                         |  122 +-
 tests/manual/performance/editorinit.html      |    6 +-
 tests/manual/performance/editorinit.js        |   76 +-
 tests/manual/performance/multipleeditors.html |    9 +
 tests/manual/performance/multipleeditors.js   |   77 +
 tests/manual/performance/multipleeditors.md   |    7 +
 tests/manual/performance/paste.html           |    8 +
 tests/manual/performance/paste.js             |   30 +
 tests/manual/performance/paste.md             |    5 +
 tests/manual/performance/richeditor.html      |   37 +-
 tests/manual/performance/richeditor.js        |   22 +-
 tests/manual/performance/richeditor.md        |    2 +
 tests/manual/performance/setdata.html         |    4 +-
 tests/manual/performance/setdata.js           |   42 +-
 22 files changed, 14189 insertions(+), 135 deletions(-)

@jodator jodator self-assigned this Feb 6, 2020
@jodator
Copy link
Contributor

jodator commented Feb 6, 2020

I've removed the automatic CKEditor Inspector attachment as in performance, like in memory leak, debugging we should minimise the external noise.

@jodator jodator merged commit 0354484 into master Feb 6, 2020
@jodator jodator deleted the i/5880 branch February 6, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance research
2 participants