Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building code snippets as dependencies of other snippets #554

Merged
merged 3 commits into from
Sep 12, 2017
Merged

Conversation

m-turek
Copy link
Contributor

@m-turek m-turek commented Sep 8, 2017

Suggested merge commit message (convention)

Internal: Support building code snippets as dependencies of other snippets. Closes #553.

@m-turek m-turek requested a review from Reinmar September 8, 2017 10:42
@m-turek m-turek changed the title Support building code snippets as dependencies of other snippets. Clo… Support building code snippets as dependencies of other snippets Sep 8, 2017
@Reinmar
Copy link
Member

Reinmar commented Sep 12, 2017

@oleq, I leave the review here for you as you're the first and only consumer of this feature ;P

@Reinmar Reinmar requested a review from oleq September 12, 2017 14:04
@oleq
Copy link
Member

oleq commented Sep 12, 2017

It works for me in ckeditor/ckeditor5-ui#299 so I'm not gonna investigate why ;-)

@oleq oleq merged commit a955285 into master Sep 12, 2017
@oleq oleq deleted the t/553 branch September 12, 2017 14:31
mlewand pushed a commit that referenced this pull request May 1, 2020
Feature: The `BlockToolbar` should group items when there is no place to show them all. Closes #6449. Closes #6575. Closes #6570.

Bulletproofed the `ToolbarView#maxWidth` and items grouping when the toolbar is invisible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants