-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved utils to ckeditor5-dev-utils
package
#261
Conversation
I updated modules depending on utils, added `ckeditor5-dev-utils` to `package.json` and fixed build task to reflect needed changes in `ckeditor5-dev-utils` package.
ckeditor5-dev-utils
package.ckeditor5-dev-utils
package
Why do we have to close ckeditor/ckeditor5-dev-task-lint#2 before this PR? This PR is only about dev utils, so what has linting to do with it? |
It is because |
Ah, makes sense :). |
|
OK, I should close https://github.com/ckeditor/ckeditor5-dev-utils/pull/2 first. |
PRs in dev-utils and dev-lint are closed, so this PR can now be reviewed. First thing that should be done is running |
@@ -35,6 +35,7 @@ | |||
"benderjs-promise": "^0.1.0", | |||
"benderjs-sinon": "^0.3.0", | |||
"chai": "^3.4.0", | |||
"ckeditor5-dev-utils": "ckeditor/ckeditor5-dev-utils", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package is located under devDependencies
and it feels like a natural way to use such dev-utils package. But this way gulp init
task will not put this package in development mode (it only takes dependencies
from package.json
). Is this intentional? This is utilities package but it is still developed by us, so this might be helpful. Maybe we need some option for gulp init
task to also scan devDependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional. The linting package will be required by all other packages anyway and using links everywhere makes no sense. So I think we should use a normal workflow here with releases and publishing. I even wrote in #215 (comment) that we need to update package.json
after we finish refactoring to use versioned packages.
Fix: Link selection attributes should be cleared after inserting a link via `Model#insertContent()` for better UX. Closes #6053.
Resolves: #252
WARNING This PR can be closed only after closing those PRs: https://github.com/ckeditor/ckeditor5-dev-utils/pull/2 and https://github.com/ckeditor/ckeditor5-dev-task-lint/pull/2
I updated modules depending on utils, added
ckeditor5-dev-utils
topackage.json
and fixed build task to reflect needed changes inckeditor5-dev-utils
package.