Treat type dependencies as production dependencies #17724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
reviewed
Jan 9, 2025
packages/ckeditor5-ui/package.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| "main": "src/index.ts", | |||
| "dependencies": { | |||
| "@ckeditor/ckeditor5-core": "44.1.0", | |||
| "@ckeditor/ckeditor5-editor-multi-root": "44.1.0", | |||
There was a problem hiding this comment.
I would get rid of this dependency in this PR.
niegowski
reviewed
Jan 13, 2025
niegowski
requested changes
Jan 13, 2025
Have you noticed any other examples than this one — #17724 (comment)? This one is expected. |
niegowski
previously approved these changes
Jan 16, 2025
niegowski
previously approved these changes
Jan 17, 2025
niegowski
previously approved these changes
Jan 20, 2025
…d urls. (#17752) Feature (utils): Add a `collectStylesheets` helper function to retrieve stylesheets from the provided URLs.
filipsobol
force-pushed
the
types-as-dependencies
branch
from
99c4438 to
c905b6b
Compare
|
Continued in #17790. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Treat type dependencies as production dependencies. Fixes #17213.