Editing images not in CKBox #15423
Merged
Editing images not in CKBox #15423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
commented
Nov 28, 2023
packages/ckeditor5-ckbox/src/ckboximageedit/ckboximageeditcommand.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ckbox/src/ckboximageedit/ckboximageeditcommand.ts
Outdated
Show resolved
Hide resolved
arkflpc
commented
Nov 30, 2023
packages/ckeditor5-ckbox/src/ckboximageedit/ckboximageeditcommand.ts
Outdated
Show resolved
Hide resolved
pszczesniak
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Works nice 🎉 just few small things:
- In manual test i suggest to remove
data-ckbox-resource-id="example-id-for-image"from example image (throws an error while we want to edit it cause it's not a real CKBox image). - After adding an image from
imguri can clickeditbut if i resign (back arrow button) theeditbutton is still active (video)
Screen.Recording.2023-12-04.at.15.04.54.mov
| */ | ||
| private _canEdit: ( element: ModelElement ) => boolean; | ||
|
|
||
| private _prepareOptions: AbortableFunc<[ ProcessingState ], Promise<Record<string, unknown>>>; |
There was a problem hiding this comment.
Missing function description.
pszczesniak
approved these changes
Dec 5, 2023
niegowski
reviewed
Dec 5, 2023
Comment on lines
+26
to
+27
| * The CKBox editing feature. It introduces the {@link module:ckbox/ckboxcommand~CKBoxCommand CKBox command} and | ||
| * {@link module:ckbox/ckboxuploadadapter~CKBoxUploadAdapter CKBox upload adapter}. |
There was a problem hiding this comment.
This comment requires fixing. It does not describe this plugin.
| 'image/tiff': 'tiff' | ||
| }; | ||
|
|
||
| export function convertMimeTypeToExtension( mimeType: string ): string { |
| return MIME_TO_EXTENSION[ mimeType ]; | ||
| } | ||
|
|
||
| export async function getContentTypeOfUrl( url: string, options: { signal: AbortSignal } ): Promise<string> { |
| if ( allowExternalImagesEditing == 'origin' ) { | ||
| const origin = global.window.location.origin; | ||
|
|
||
| return src => src.startsWith( origin + '/' ); |
There was a problem hiding this comment.
Will this work correctly with relative URLs?
| @@ -169,6 +210,16 @@ export default class CKBoxImageEditCommand extends Command { | |||
| return states; | |||
| } | |||
|
|
|||
| private _checkIfElementIsBeingProcessed( selectedElement: ModelElement ) { | |||
There was a problem hiding this comment.
It's private and the name is long enough.
mmotyczynska
reviewed
Dec 5, 2023
|
|
||
| /** | ||
| * Initializes the `ckbox` editor configuration. | ||
| * Checks if the at least one image plugin is loaded. |
There was a problem hiding this comment.
Suggested change
| * Checks if the at least one image plugin is loaded. | |
| * Checks if at least one image plugin is loaded. |
| @@ -169,6 +210,16 @@ export default class CKBoxImageEditCommand extends Command { | |||
| return states; | |||
| } | |||
|
|
|||
| private _checkIfElementIsBeingProcessed( selectedElement: ModelElement ) { | |||
There was a problem hiding this comment.
It's private and the name is long enough.
Comment on lines
+15
to
+18
| /** | ||
| * @internal | ||
| */ | ||
| export function createEditabilityChecker( |
There was a problem hiding this comment.
Missing function description.
| }; | ||
| } | ||
|
|
||
| function createUrlChecker( |
There was a problem hiding this comment.
Missing function description.
Comment on lines
+207
to
+211
| export function convertMimeTypeToExtension( mimeType: string ): string { | ||
| return MIME_TO_EXTENSION[ mimeType ]; | ||
| } | ||
|
|
||
| export async function getContentTypeOfUrl( url: string, options: { signal: AbortSignal } ): Promise<string> { |
There was a problem hiding this comment.
Missing functions descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (ckbox): Integration with CKBox editing of images not from CKBox.
Closes https://github.com/cksource/ckeditor5-commercial/issues/5746#.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.