Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to getOptimalPosition to handle cases with scrollable ancestors #14755

Merged
merged 36 commits into from
Sep 8, 2023
Merged

Improvements to getOptimalPosition to handle cases with scrollable ancestors #14755

merged 36 commits into from
Sep 8, 2023

Commits on Aug 3, 2023

  1. Merge branch 'master' into ck/5328-ballon-panel-sticks-out-v2

    @oleq
    oleq committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ee806e5 View commit details
    Browse the repository at this point in the history

  2. Revert "Reverted a fix for balloons sticking out of a limiter." 

    This reverts commit c41cd7e, reversing
changes made to 3af90be.
    @oleq
    oleq committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    34404b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Preserve Rect source while getIntersection() to allow further use of … 

    …getVisible(). Rect#getVisible() should exclude parents with overflow: visible.
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    66d6a6d View commit details
    Browse the repository at this point in the history

  2. Do not engage the BPV viewportStickyNorth position unless part of the… 

    … target went off the boundaries.
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    199ea15 View commit details
    Browse the repository at this point in the history

  3. Streamlined getOptimalPosition() logic. Now it is built on top of Rec… 

    …t#getVisible().
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a5ccb11 View commit details
    Browse the repository at this point in the history

  4. Took advantage better getOptimalPosition() to handle "Powered by" log… 

    …o in corner cases with multiple scrollable ancestors.
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a7d3d01 View commit details
    Browse the repository at this point in the history

  5. Tests: Improved Powered by manual test with multiple scrollable ances… 

    …tors.
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8f5557d View commit details
    Browse the repository at this point in the history

  6. Tests: Added viewport offsets to the #5328 manual test in the UI for … 

    …more real-life scenarios.
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    515b824 View commit details
    Browse the repository at this point in the history

  7. Tests: Improved RectDrawer's styles. Exported a reusable background s… 

    …tyle preset with diagonal lines.
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6595fb4 View commit details
    Browse the repository at this point in the history

  8. Tests: Added additional cases to the Rect#getVisible() manual test.

    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1442c63 View commit details
    Browse the repository at this point in the history

  9. Moved the "absolute rect" logic from getOptimalPosition to Rect. Addr… 

    …essed the issue of the BlockToolbar not positioning properly due to window scroll.
    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    cf5e63a View commit details
    Browse the repository at this point in the history

  10. Tests: Used lower z-index for RectDrawer because it go too obtrusive.

    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c14d3f1 View commit details
    Browse the repository at this point in the history

  11. Fine-tuned the viewportStickyNorth position.

    @oleq
    oleq committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2d19f70 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Exported shared styles for RectDrawer.

    @oleq
    oleq committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    13d1a7d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Tests: Updated imports in Rect#getVisible manual test.

    @oleq
    oleq committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c9940eb View commit details
    Browse the repository at this point in the history

  2. Tests.

    @oleq
    oleq committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cb1f6e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'master' into ck/5328-ballon-panel-sticks-out-v2

    @pszczesniak
    pszczesniak committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ab7d646 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Fixing tests - position.

    @pszczesniak
    pszczesniak committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1647160 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. PoweredBy tests fixed.

    @pszczesniak
    pszczesniak committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ae76f08 View commit details
    Browse the repository at this point in the history

  2. Fixing tests from dropdownview and blocktoolbar.

    @pszczesniak
    pszczesniak committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    19885ba View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Save the link in balloon - editor crash fix.

    @pszczesniak
    pszczesniak committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c13d551 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Manual test fixes for ticket 5328.

    @pszczesniak
    pszczesniak committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6ff2346 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Fixing unit test cases and change main condition to cover all cases.

    @pszczesniak
    pszczesniak committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6005780 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Streamlining logic of the StickyPanelView.

    @pszczesniak
    pszczesniak committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    4a77bf9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ck/5328-ballon-panel-sticks-out-v2

    @pszczesniak
    pszczesniak committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2db00fe View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Add missing API docs.

    @pszczesniak
    pszczesniak committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b873a7b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ck/5328-ballon-panel-sticks-out-v2

    @pszczesniak
    pszczesniak committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    94eb704 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Add missing import.

    @pszczesniak
    pszczesniak committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5f6e51b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge branch 'master' into ck/5328-ballon-panel-sticks-out-v2

    @pszczesniak
    pszczesniak committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    759c50b View commit details
    Browse the repository at this point in the history

  2. Fixes after code review.

    @pszczesniak
    pszczesniak committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    816c7c8 View commit details
    Browse the repository at this point in the history

  3. Visualization of condition dependency between child and parent elements.

    @pszczesniak
    pszczesniak committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a5b8836 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Fix function typings.

    @pszczesniak
    pszczesniak committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b93c30e View commit details
    Browse the repository at this point in the history

  2. Remove logs.

    @pszczesniak
    pszczesniak committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8d7786d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ck/5328-ballon-panel-sticks-out-v2

    @pszczesniak
    pszczesniak committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b9cba98 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Merge branch 'master' into ck/5328-ballon-panel-sticks-out-v2

    @oleq
    oleq committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    21d1597 View commit details
    Browse the repository at this point in the history

  2. Tests: Added a missing test for Rect instances preserving source info… 

    …rmation while intersecting with another Rect.
    @oleq
    oleq committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    d8672c3 View commit details
    Browse the repository at this point in the history