Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do lists in document lists #14700

Merged
merged 62 commits into from
Sep 21, 2023
Merged

To-do lists in document lists #14700

merged 62 commits into from
Sep 21, 2023

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented Jul 31, 2023

Suggested merge commit message (convention)

Feature (list): Introducing the to-do lists compatible with the document list feature. Closes #14663.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@charlttsie
Copy link
Contributor

charlttsie commented Sep 19, 2023

@niegowski It seems like with Heading 1, the position of the checkbox is too high compared to how it looks with unordered and ordered document lists:
checkbox-position-H1

It looks better with other heading levels:
checkbox-position-h2
checkbox-position-h3

Is should probably be aligned to bottom, as it is with other document list types:
list-position

@charlttsie
Copy link
Contributor

Checkboxes next to code block items are not responsive

Steps

  1. Add the Code block plugin to http://fake.ckeditor.com:8125/ckeditor5-list/tests/manual/todo-documentlist.html
  2. Add a code block as a to-do list item
  3. Try to check the checkbox

Result
The checkbox can't be checked:

checkbox-codeblock.mp4

Additional info
Works good with other widgets (including images, tables, block quotes)

@charlttsie
Copy link
Contributor

Switching to-do list on and off on an element affects checkboxes of the list items below

Steps

  1. Open http://fake.ckeditor.com:8125/ckeditor5-list/tests/manual/todo-documentlist.html
  2. Add a couple of to-do list items and check the checkboxes for some of them
  3. Place the caret in the first list item
  4. Click the to-do list toolbar icon

Result
For a moment, checkboxes on unchecked list items get green highlight, while checked checkboxes lose the check mark:

checkboxes.mp4

Additional info
It's not reproducible with legacy to-do lists

@charlttsie
Copy link
Contributor

Alignment of to-do document list items can't be changed

Steps

  1. Add the alignment plugin to http://fake.ckeditor.com:8125/ckeditor5-list/tests/manual/todo-documentlist.html and open the manual test
  2. Add a list item
  3. Try to change the item's alignment

Result
The position of the list item doesn't change:

alignment.mp4

Additional info
Works good with other document list types and with legacy to-do lists

@niegowski
Copy link
Contributor Author

The checkbox alignment extracted to the follow-up: #15035

Other issues were solved.

@niegowski niegowski changed the title [PoC] to-do lists in document lists. To-do lists in document lists Sep 20, 2023
@niegowski niegowski marked this pull request as ready for review September 20, 2023 16:01
# Conflicts:
#	packages/ckeditor5-code-block/package.json
@charlttsie
Copy link
Contributor

@niegowski
It will probably be a follow-up but one more thing is that Track Changes is not yet supported:

checkbox-tc.mp4

@arkflpc arkflpc merged commit 613b8e2 into master Sep 21, 2023
6 checks passed
@arkflpc arkflpc deleted the ck/14663-to-do-lists-poc branch September 21, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Todo lists in Document lists
4 participants