Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #1234

Merged
merged 7 commits into from
Sep 7, 2018
Merged

Upgrade dependencies #1234

merged 7 commits into from
Sep 7, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Sep 6, 2018

Suggested merge commit message (convention)

Internal: Upgraded dev-dependencies. Closes #1203.


Additional information

mgit fetch && mgit co t/ckeditor5/1203 && mgit co master && mgit merge t/ckeditor5/1203 -- -m 'Internal: Upgraded dependencies. See ckeditor/ckeditor5#1203.' && mgit push

@pomek pomek requested a review from Reinmar September 6, 2018 07:14
@pomek
Copy link
Member Author

pomek commented Sep 6, 2018

CKEditor 5 and CKEditor 5-dev are fine.

@Reinmar
Copy link
Member

Reinmar commented Sep 6, 2018

Let's not upgrade lerna to version 3 (just yet) due to problems and other options mentioned in #1214.

@pomek
Copy link
Member Author

pomek commented Sep 6, 2018

As you wish but everything seems to work.

@pomek
Copy link
Member Author

pomek commented Sep 6, 2018

Almost everything:

image

So I'm reverting lerna's changes.

@Reinmar
Copy link
Member

Reinmar commented Sep 6, 2018

I actually tried to upgrade to lerna@3 myself and I knew it caused some issues (although, I stumbled upon something else than you).

@pomek
Copy link
Member Author

pomek commented Sep 6, 2018

lerna@^2 produces the same directories.

Lerna 3 changes some things in configuration (lerna init resolves problems) and on CI I needed to add --no-ci option because of the missing package-lock.json file that caused other problems.

Docs worked, samples in the docs as well. I didn't check the builds.

@pomek
Copy link
Member Author

pomek commented Sep 6, 2018

After reverting lerna's changes, ckeditor5-dev does not require any changes.

@Reinmar Reinmar merged commit 3f06f02 into master Sep 7, 2018
@Reinmar
Copy link
Member

Reinmar commented Sep 7, 2018

After reverting lerna's changes, ckeditor5-dev does not require any changes.

There are packages in ckeditor5-dev that we should upgrade now. For instance:

image

And there are more in ckeditor5-dev that require updates. We should keep them in sync with what we use in ckeditor5 to avoid problems like – postcss-loader works when you run tests, but fails when you try to rebuild the editor (because a different version is used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants