New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ck/11724 ts engine #12188

Merged

pomek merged 30 commits into master from ck/11724-ts-engine

Aug 4, 2022

Contributor

arkflpc commented Aug 1, 2022

Suggested merge commit message (convention)

Other (engine): Rewrite ckeditor5-engine package to TypeScript. Closes #11724.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

arkflpc and others added 12 commits

July 15, 2022 15:14


          Merge branch 'ck/epic/11708-typescript-first-release' into ck/epic/11…

164f369

…708-migrate-typescript-mvp


          Merge branch 'master' into ck/epic/11708-migrate-typescript-mvp

6ffd605


          Merge remote-tracking branch 'origin/master' into ck/epic/11708-migra…

a06baa5

…te-typescript-mvp


          Engine TypeScript Work in Progress

c9d6964


          WiP.

1d6891d


          Revert "Better BR elements handling"

946877e


          Fixed premature iterator consumption.

2acbcb3


          Fixed empty element children handling.

e5982db


          Merge branch 'master' into engine-wip

083ffab


          Fix tsconfig.json

e6ca30e


          Added packages/ckeditor5-engine/tsconfig.release.json

7e77ea1


          Fix ckeditor5-engine/package.json

5bd94bf

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/tests/view/utils-tests/createroot.js Outdated Show resolved Hide resolved


          Added missing 'selectionChange' event type.

9d81d2b

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/src/controller/datacontroller.ts Outdated Show resolved Hide resolved


          Added conversion events prefixes.

b996d3a

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/src/view/treewalker.ts Show resolved Hide resolved

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/src/view/treewalker.ts Outdated Show resolved Hide resolved

arkflpc commented

View reviewed changes

Contributor Author

arkflpc left a comment

Add typed events for view/observer/*

packages/ckeditor5-engine/src/model/model.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/document.ts Outdated Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/documentfragment.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/documentfragment.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/documentfragment.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/documentselection.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/documentselection.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/documentselection.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/downcastwriter.ts Outdated Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/downcastwriter.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/downcastwriter.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/element.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/element.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/element.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/element.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/element.ts Show resolved Hide resolved

arkflpc commented

View reviewed changes

packages/ckeditor5-engine/src/view/upcastwriter.ts Outdated Show resolved Hide resolved

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/src/view/selection.ts Outdated Show resolved Hide resolved

arkflpc and others added 2 commits

August 2, 2022 12:23


          TS: bringing code coverage back to 100%


          Review fixes.

f89b68b

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/src/view/rawelement.ts Show resolved Hide resolved

arkflpc added 3 commits

August 2, 2022 14:13


          TS: Add typed events for observers

99be45b


          Merge branch 'ck/11724-ts-engine' of github.com:ckeditor/ckeditor5 in…

b9213fd

…to ck/11724-ts-engine


          TS: mix changes

448971b

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/src/view/observer/bubblingemittermixin.ts Outdated Show resolved Hide resolved

niegowski added 7 commits

August 2, 2022 16:27


          Review fixes.

26fde8b


          Review fixes.

d62005d


          Review fixes.

d8cd2e1


          Review fixes.

69983fe


          Narrowed parameters for DOM-View mapping.

fc7eb06


          Fixed code indentation.

7229d0c


          Fixed code indentation.

c3f7c57

arkflpc requested a review from pomek

August 3, 2022 12:24

pomek approved these changes

View reviewed changes

Member

pomek left a comment

I checked the release-oriented things and LGTM.


          Fixed code indentation.

411da53

niegowski reviewed

View reviewed changes

packages/ckeditor5-engine/src/model/position.ts Show resolved Hide resolved

Reinmar mentioned this pull request

Migrate CKEditor 5 to TypeScript #11704

Closed

arkflpc added 3 commits

August 4, 2022 11:36


          Merge branch 'master' into ck/11724-ts-engine

2fcbd83


          TS: engine - add comment about unreachable code

f2e7b49


          TS: engine - add previous *.js files as _src

3541eef

pomek merged commit dd14cd2 into master

pomek deleted the ck/11724-ts-engine branch

August 4, 2022 11:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet