Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship CKEditor 5 DLLs 🚀 #9145

Closed
Reinmar opened this issue Mar 2, 2021 · 1 comment
Closed

Ship CKEditor 5 DLLs 🚀 #9145

Reinmar opened this issue Mar 2, 2021 · 1 comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:extending-builds resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 2, 2021

📝 Provide a description of the new feature

Currently, CKEditor 5 does not come with a ready-to-use DLL builds and DLL-compatible plugin builds.

We made the editor DLL-ready and there's a guide how to generate such builds, but more work needs to be put into DLLs becoming the major integration method.

Update: DLL-compatible builds of ckeditor5 and ckeditor5-* packages are available on npm. The aforementioned guide "CKEditor 5 DLL builds" was updated and shows the quick path to start using DLL-based editor. In the meantime we also made the collaboration features DLL-compatible meaning that this integration method is supported all across our platform.

What's next?

As explained in the previous section, DLLs are support across our entire platform. However, there's an idea to make them the main integration method. This would be a large-scale effort as we'd need to rethink the installation paths, how OB works, what do we ship, how API docs look, etc. This is future.

Challenges:

  • Turning current builds into DLL builds.
  • Rewriting most of the "Builds" section in the guides.
  • Turning API docs upside down to expose the index files and the globals.
  • Understanding the limitations of this method (and reverting some of the above changes :D).
  • Explaining how to write DLL-compatible plugins.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@Reinmar Reinmar added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). domain:dx This issue reports a developer experience problem or possible improvement. squad:dx domain:extending-builds labels Mar 2, 2021
@Reinmar Reinmar added this to the nice-to-have milestone Mar 2, 2021
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:dx labels Sep 9, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Sep 19, 2022
@Witoso
Copy link
Member

Witoso commented Dec 12, 2023

We are taking a different approach to delivering packages with built code. Check out a detailed RFC on the new installation methods: #15502 🎉

@Witoso Witoso closed this as completed Dec 12, 2023
@Witoso Witoso added the resolution:expired This issue was closed due to lack of feedback. label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:extending-builds resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants