Default language (en) is not loading with RequireJS (AMD) #914

nao-pon · 2018-03-18T14:31:15Z

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

CKEditor 5 build v1.0.0-beta.1

📋 Steps to reproduce

Example Code

<html>
<head>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.5/require.min.js"></script>
    <script>
        require(['https://cdn.ckeditor.com/ckeditor5/1.0.0-beta.1/balloon/ckeditor.js'], function(cke5) {
            cke5.create(document.getElementById("edit"));
        });
    </script>
</head>
<body>
    <div id="edit">
        <h1>For Test</h1>
    </div>
</body>
</html>

❎ Actual result

Uncaught ReferenceError: CKEDITOR_TRANSLATIONS is not defined at ckeditor.js:7

Reinmar · 2018-03-19T07:34:39Z

@ma2ciek could you check it?

ma2ciek · 2018-03-19T10:17:45Z

Yes, it's a bug. When loading editor's build through RequireJS, the exported function evaluates after the translations added at the end of that script. Maybe to ensure the script's asynchrony or lazy loading, I don't know.

The Webpack's UMD looks as follows:

(function(e, t) {
    'object' == typeof exports && 'object' == typeof module ? module.exports = t() : 'function' == typeof define && define.amd ? define([], t) : 'object' == typeof exports ? exports.BalloonEditor = t() : e.BalloonEditor = t()
}
)('undefined' == typeof self ? this : self, function() {
   // Script
} );

So for all options despite AMD, the function with script's body runs synchronously and translations should be added correctly. I didn't know that behavior.

Reinmar · 2018-03-19T10:24:42Z

Do you have an idea for how to workaround this?

ma2ciek · 2018-03-19T10:29:34Z

I'm thinking now about some smart reversing, so the translation will be added globally before the editor. I'll make some quick POC.

ma2ciek · 2018-03-19T11:03:31Z

We could have something like this:

cke-build.js

var CKEDITOR_TRANSLATIONS = { 'en': { ... } };
// Script

pl.js

CKEDITOR_TRANSLATIONS[ 'pl' ] = { ... }

And translation-service will use CKEDITOR_TRANSLATIONS or copy of that as a dictionary.

But now I'm unsure about running many editors. If it will affect previous ones as require.js is asynchronous in loading them.

Reinmar · 2018-03-19T11:10:41Z

TBH, you'd need to remind me how it works now :D Which module exports what and how it's executed by RequireJS.

ma2ciek · 2018-03-19T11:39:01Z

Sure ;)

Now the workflow is as following:

translation-service is a service that provides translations for all t() calls and exports add function globally, so it can be used later: window.CKEDITOR_TRANSLATIONS.add( 'en', {} )

The English translations are added to the build at the end, so the build for the balloon editor looks like this:

(function(e, t) {
    'object' == typeof exports && 'object' == typeof module ? module.exports = t() : 'function' == typeof define && define.amd ? define([], t) : 'object' == typeof exports ? exports.BalloonEditor = t() : e.BalloonEditor = t()
}
)('undefined' == typeof self ? this : self, function() {
   // Whole code of the CKEditor5 with exported BalloonEditor.


} );

CKEDITOR_TRANSLATIONS.add( 'en', {} );

The RequireJS's define function is called in the second line: define([], t), where the t is the second parameter of the function and it becomes a function with the whole CKEditor's logic. I don't know how RequireJS invokes that t function later, but as we can see it runs it async, so the CKEDITOR_TRANSLATIONS.add( 'en', {} ); is called before t and the error is thrown.

Reinmar · 2018-03-19T12:21:33Z

OK, so the module's wrapping function is executed on demand – when first requiring (aka importing) anything from such a module.

Perhaps, the module added by CKEditor5WebpackPlugin could require the translation-service module first to force its evaluation? This may cause some ugly circular dependency which RequireJS might not be able to solve, but it's worth checking.

ma2ciek · 2018-03-19T12:30:28Z

But then we'd have to know what's the name of the current AMD module and I'm not sure if that information is available.

Reinmar · 2018-03-19T12:38:07Z

Current AMD modules? What do you mean by "current" and why we'd need to know that?

To be clear – I meant that perhaps CKEditor5WebpackPlugin could add something like this:

// Import whatever from there to force its evalutation.
import add from '@ckeditor/ckeditor5-utils/src/translation-service';

CKEDITOR_TRANSLATIONS.add( 'en', {} );

Is it possible?

Reinmar · 2018-03-19T12:44:45Z

Actually, I guess – not. And the reason would be our file split (than lang files are separated), yes?

ma2ciek · 2018-03-19T12:45:55Z

I misunderstood your last question. That's not possible due to the fact that all webpack imports with our stuff are resolved and land in the 4th. line - see my snippet above.

ma2ciek · 2018-03-19T12:53:13Z

Webpack provides an UMD wrapper, so the code resolved from all imports is actually wrapped in the function, which is later called depending on the runtime - define( fn, [] ) for require.js, module.exports.BalloonEditor = fn() for common.js or window.BalloonEditor = fn() for manually added script.

ma2ciek · 2018-03-19T12:55:02Z

#914 (comment) - I've tested that approach and it works, because the CKEDITOR_TRANSLATIONS is declared before the async code execution.

Reinmar · 2018-03-19T13:03:25Z

Yeah, I came to the same conclusion that we can't use add() and that we should manually push stuff to CKEDITOR_TRANSLATIONS. However, I'd use some safe solution like:

CKEDITOR_TRANSLATIONS.pl = Object.assign( CKEDITOR_TRANSLATIONS.pl || {}, ...translations );

ma2ciek · 2018-03-19T13:12:32Z

IMO, we may want to add translations for each language only once. I don't see a use case for the safer version.

Reinmar · 2018-03-19T13:16:43Z

People adding their translations from outside of a build?

BTW, what I proposed is exactly what add() does now:

export function add( lang, translations ) {
	dictionaries[ lang ] = dictionaries[ lang ] || {};

	Object.assign( dictionaries[ lang ], translations );
}

And with the whole CKEDITOR_TRANSLATIONS object we're safe now too:

window.CKEDITOR_TRANSLATIONS = window.CKEDITOR_TRANSLATIONS || {};

I'd keep that.

ma2ciek · 2018-03-19T13:20:42Z

People adding their translations from outside of a build?

Right, so I'll keep the safer version.

I'll prepare a PR with the fix.

ma2ciek · 2018-03-19T13:25:51Z

I'll add require.js manual tests to builds too within that PR.

ma2ciek · 2018-03-20T10:03:49Z

I've pushed changes to the t/914 branches and I'm writing here a description what is done so far.

CKEditor5WebpackPlugin

RawSource is used instead of normal objects for generating assets because there was a problem with ConcatSource used internally by Webpack.BannerPlugin
Name of the event being listening to is changed (from emit to optimize-chunk-assets) to emit assets before Webpack.BannerPlugin, so the license is added at the correct place (not after translations).

MultipleLanguageTranslationService (ckeditor5-dev-utils)

Changed body of generated chunks and translations. Now there's something like this at the beginning because RequireJS can load these translations in a different order:

'(function(d){' +
	`d['${ language }']=Object.assign(` +
		`d['${ language }']||{},` +
		`${ stringifiedTranslations }` +
	')' +
'})(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));'

It slightly increases the size of assets, but allows to use both approaches:

<script src="translations/pl.js">
<script>requirejs( [ 'ckeditor.js' ], ClassicEditor => {} )</script>

<script>requirejs( [ 'ckeditor.js', 'translations/pl.js' ], ClassicEditor => {} )</script>

TranslationService (ckeditor5-utils)

Removed add() function (which was adding translations).
Instead, this service uses now window.CKEDITOR_TRANSLATIONS to get all translations when they're needed (when translate() function is invoked).

Builds and samples:

We can improve our samples and add UMD sample and translation sample. (These samples will only need HTML files and it's not possible to create them using manual tests.

nao-pon · 2018-03-20T17:41:02Z

@Reinmar , @ma2ciek Thanks! I'm testing on the demo site of elFinder to edit the HTML file. It seems work perfectly!

ma2ciek · 2018-03-21T08:56:38Z

I'm glad that these changes work for you well :) They should land in the next beta version.

Reinmar · 2018-03-21T22:05:22Z

Your changes look really good. And kudos for the post with the summary.

I've got just two questions:

Will the language files be transpiled if Babel is enabled? I'm asking because you used an arrow function there. In other words, we need a final answer for https://github.com/ckeditor/ckeditor5-dev/pull/385/files#diff-c7651cbe9bf62ae0195e3db361131b75R216
Could you add in ckeditor5-build-classic (only) those samples using Require.JS? Perhaps there's some way to add them in tests/? I think that the manual test server doesn't look for .html files anyway, so we can add them there and simply write plain-HTML pages (kinda like sample/index.html). We'll use them only on special occasions anyway.

pomek · 2018-03-22T09:46:03Z

I think that the manual test server doesn't look for .html files anyway

It does. If the *.js file exists, corresponding *.html and *.md files also have to exist.

Reinmar · 2018-03-22T09:57:16Z

It does. If the *.js file exists, corresponding *.html and *.md files also have to exist.

But we don't need a JS file in this case. To make a sample for testing requirejs we need a simple HTML file with no assets (requirejs can be loaded from CDN and CKEditor 5 build from the ../build/ directory).

pomek · 2018-03-22T09:57:52Z

Right.

ma2ciek · 2018-03-22T10:39:12Z

Could you add in ckeditor5-build-classic (only) those samples using Require.JS? Perhaps there's some way to add them in tests/? I think that the manual test server doesn't look for .html files anyway, so we can add them there and simply write plain-HTML pages (kinda like sample/index.html). We'll use them only on special occasions anyway.

Manual tests should depend on the HTML files and the rest should be optional to make it work. The second problem is that with the current implementation all files are moved or compiled to ckeditor5/build/.manual-tests directory. We'd have to somehow copy there the CKEditor5's builds, so the whole process would have to be smarter.

Will the language files be transpiled if Babel is enabled? I'm asking because you used an arrow function there. In other words, we need a final answer for ckeditor/ckeditor5-dev/pull/385/files#diff-c7651cbe9bf62ae0195e3db361131b75R216

Right, I almost forgot about it. Webpack's loaders won't touch this code so we should provide somehow the transpiled version if somebody uses babel etc. I think we can achieve this either by:

providing by default the ES5 version - translation files will grow a bit.
launching loaders that match JS files on these files - that would be tricky and dangerous
specifying the version of the ES in CKEdtirorWebpackPlugin, so we can use much shorter (ES6) version by default, but will have the ES5 version available too if somebody needs it.

Reinmar · 2018-03-26T09:14:14Z

providing by default the ES5 version - translation files will grow a bit.

AFAICS, each language file (in a build) will contain just one function() call, so the difference is completely negligible. Let's use ES5-safe version by default.

Manual tests should depend on the HTML files and the rest should be optional to make it work. The second problem is that with the current implementation all files are moved or compiled to ckeditor5/build/.manual-tests directory. We'd have to somehow copy there the CKEditor5's builds, so the whole process would have to be smarter.

It can be simpler than that. We don't need to use the test:manual script for everything. To satisfy the current case we simply need to find a place in a build's directory structure to place a test HTML file which will be ignored when publishing this to npm. A good place for that is the tests/ directory. The fact that test:manual isn't able to build that is not a big problem – it's not perfect, but you can use your local HTTP server or whatever to open it in a browser. To be clear, it'd be this for me:

http://localhost/ckeditor5/packages/ckeditor5-build-classic/tests/<whatever-we-need-here>/sample-with-requirejs.html

Reinmar · 2018-03-26T09:20:46Z

It can be simpler than that.

To make it clear – let's not overcomplicate this. We need one test file that we'll use very rarely for this specific case. If we'll find out that this is a recurring problem we can think about a more general solution.

Other: Removed `translation-service~add()` function in favor of using safer, always available, manual approach to extending `CKEDITOR_TRANSLATIONS` global. See ckeditor/ckeditor5#914. BREAKING CHANGES: The `translation-service~add()` function was removed. See `translation-service` module docs to learn how to add translations.

Fix: Enabled builds to work with RequireJS. Closes ckeditor/ckeditor5#914. BREAKING CHANGES: Due to a new format of translation snippets the new version of `CKEditor5WebpackPlugin` will only be compatible with CKEditor 5 v1.0.0-beta.2 or later.

…tor5#914.

Reinmar · 2018-03-27T15:18:20Z

The new version of @ckeditor/ckeditor5-dev-webpack-plugin will fix this issue. However, it will only be compatible with beta.2 of CKEditor 5 so we need to wait a bit with releasing it.

Besides, I added two manual tests in ckeditor5-build-classic – theses tests are only accessible through a local HTTP server. Manual tests server doesn't pick them up.

Reinmar · 2018-04-10T10:37:13Z

OK, beta.2 (and beta.3 in case of builds) is out and builds will work fine with RequireJS now.

nao-pon · 2018-04-11T04:27:18Z

👍 OK, Thanks! but CDN items (ex. https://cdn.ckeditor.com/ckeditor5/1.0.0-beta.2/classic/ckeditor.js) are not found.

Reinmar · 2018-04-11T08:08:46Z

Turns out that CDN isn't updated yet. Working on this.

* Feature: Added the image upload button to the build. See ckeditor/ckeditor5#870. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v1.0.0-beta.1. * Internal: Updated links to CKEditor 5 website. [skip ci] * Docs: Typo in README fixed. [skip ci] * Removed duplicated "ImageUpload" plugin. * Internal: Updated dependencies. * Tests: Added manual tests for translating editors. See ckeditor/ckeditor5#914. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v1.0.0-beta.2. * Fix: Translations should work when CKEditor was loaded using RequireJS. See ckeditor/ckeditor5-dev#914. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Build. * Release: v1.0.0-beta.3. * Docs: Fixed link in the readme. [skip ci] * Docs: Mentioned previous release in the changelog. [skip ci] * Internal: Updated keywords. [skip ci] * Internal: Build. * Internal: Fixed keywords. [skip ci] * Internal: Improved license file. * Docs: Changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v1.0.0-beta.4. * Other: Changed the license to GPL2+ only. See ckeditor/ckeditor5#991. BREAKING CHANGE: The license under which CKEditor 5 is released has been changed from a triple GPL, LGPL and MPL license to a GPL2+ only. See ckeditor/ckeditor5#991 for more information. * Internal: Updated dependencies. * Internal: Build. * Docs: Changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v10.0.0. * Docs: Changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v10.0.1. * Adjusted code to the changes in ckeditor5-editor-classic. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Build. * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v10.1.0. * Switched to [email protected] and UglifyJsWebpackPlugin. * Switched back to banner with exclamation mark. * Webpack up. * Bump, bump. * Hide unnecessary warnings. * Improved comments. * Internal: Upgraded version of Node.js. See ckeditor/ckeditor5-dev#417. * Docs: Improved the package description. * Docs: Improved keywords and the readme. [skip ci] * Internal: Aligned code to changes in ckeditor5-core. See ckeditor/ckeditor5-core#140. * Internal: Build. * Other: Changed the build structure. TODO. Closes ckeditor/ckeditor5#1038. * Internal: Build. * Internal: Build. * Internal: Build. * Internal: Build. * Internal: Build. * Removed unnecessary comment in `webpack.config.js`. * Internal: Further builds simplifications plus some comments. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v11.0.0. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Internal: Build. * Release: v11.0.1. * Docs: Changed links to documentation. See ckeditor/ckeditor5#1192. * Internal: Upgraded dependencies. * Docs: Changed links to documentation. See ckeditor/ckeditor5#1192. * Upgraded version of ESLint. * Added build screenshot to README.md. * Added Media Embed and Table features to the build. * Internal: Build. * Tests: Updated build tests to the new toolbar configuration. * Internal: Build. * That option got renamed in the meantime. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v11.1.0. [skip ci] * Docs: Fixed invalid merge in the readme. * Docs: Changelog. [skip ci] * Internal: Build. * Release: v11.1.1. [skip ci] * Docs: Made contributing guide link to our docs. [skip ci] * Feature: Introduced the Paste From Office feature. * Feature: Introduced the CKFinder integration plugin. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v11.2.0. [skip ci] * Introduced a linter and Travis. * Added a configuration for ESLint. * Directory created by Mgit on CI must be ignored as well. * Code style in tests. * Update raw-loader dependency. * Aligned Travis configuration after switching to Yarn. See ckeditor/ckeditor5#1214. * Docs: Added build status badges to the README. See: ckeditor/ckeditor5#1236. * Fixed formatting in Travis configuration file. * Updated deps. * Add memory leak test. * Add missing ckeditor5-core dependency. * Internal: Bumped the year. [skip ci] * Upgraded version of husky. * Other: Upgraded minimal versions of Node and npm. See: ckeditor/ckeditor5#1507. * Internal: Updated deps. * Internal: Build. * Internal: Build. * Docs: Updated the homepage link. [skip ci] * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.0.0. [skip ci] * Internal: Removed unnecessary and added missing deps. * Internal: Introduced Slack Notifications for this repository on CI. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.1.0. [skip ci] * Internal: Changed a way how to install Chrome on Travis. [skip ci] * Internal: Updated the license header. See ckeditor/ckeditor5#1557. [skip ci] * Internal: Build. * Internal: Updated license section in README. See ckeditor/ckeditor5#1557. [skip ci] * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.2.0. [skip ci] * Removed BrowserStack from the repository. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.3.0. [skip ci] * Internal: Ping CI. * Internal: Bumped up deps. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.3.1. [skip ci] * All tests require an image that exists. It will not cause the 404 error. * Bumped style-loader to v1.0.0. Aligned the webpack config to the new loader API. * Bumped up raw-loader, uglifyjs-webpack-plugin, webpack, and webpack-cli dependencies. * Internal: Build. * Internal: Build. * Other: Changed the URL under bugs key in package.json file. Now we have one issue tracker. See ckeditor/ckeditor5#1988. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.4.0. [skip ci] * Internal: Make CI green. * Docs: Removed gitter badge. See ckeditor/ckeditor5#2037. [skip ci] * Internal: Upgraded CI environment to use Xenial version of the distro. See ckeditor/ckeditor#2041. * Feature: Enabled the indent feature in the build. * Internal: Build. * Tests: Updated the test. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v15.0.0. [skip ci] * Internal: Make CI green. * Internal: Updated the GitHub PR template because all packages share the same issue tracker now (see ckeditor/ckeditor5#5576). * Internal: Enabled stylelint in the package. * Internal: Allowed empty input in the stylelint script to avoid errors when no files are found. Added missing stylelint-config-recommended dependency. * Internal: Added the stylelintrc config. [skip ci] * Used the external stylelint-config-ckeditor5 package for stylelint configuration. * Replaced UglifyJS with Terser. * Internal: Build. * Internal: Added a missing pacakge dev-dependencies. See ckeditor/ckeditor5#5856. * Internal: Made the error initialization catch statements more informative. * Minor improvements to error messages used in manual tests and a sample. [skip ci] * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v16.0.0. [skip ci] * Internal: Make CI green. * Internal: Added blog post URL. [skip ci] * Internal: Fixed blog post URL for the 11.0.0 release. [skip ci] * Internal: Added config for package.json to .editorconfig. See #318. * Internal: Bumped the year. [skip ci] Co-authored-by: Piotrek Koszuliński <[email protected]> Co-authored-by: Kamil Piechaczek <[email protected]> Co-authored-by: Anna Tomanek <[email protected]> Co-authored-by: Maciej Bukowski <[email protected]> Co-authored-by: Aleksander Nowodzinski <[email protected]> Co-authored-by: Damian Konopka <[email protected]> Co-authored-by: Maciej <[email protected]> Co-authored-by: Marek Lewandowski <[email protected]>

…tor5#914.

Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 19, 2018

ma2ciek self-assigned this Mar 19, 2018

ma2ciek mentioned this issue Mar 20, 2018

Enable ckeditor5 builds to work with RequireJS ckeditor/ckeditor5-dev#385

Merged

Reinmar added status:confirmed labels Mar 21, 2018

Reinmar added this to the iteration 15 milestone Mar 21, 2018

Reinmar mentioned this issue Mar 27, 2018

Removed translation-utils's add() ckeditor/ckeditor5-utils#232

Merged

Reinmar closed this as completed in ckeditor/ckeditor5-dev#385 Mar 27, 2018

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Mar 27, 2018

Tests: Added manual tests for translating editors. See ckeditor/ckedi…

0a00921

…tor5#914.

Reinmar mentioned this issue Mar 27, 2018

Release ckeditor5-dev-webpack-plugin and bump its version in builds #926

Closed

JDinABox pushed a commit to JDinABox/ckeditor5-build-markdown that referenced this issue Sep 6, 2021

Tests: Added manual tests for translating editors. See ckeditor/ckedi…

86f54a1

…tor5#914.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Default language (en) is not loading with RequireJS (AMD) #914

Default language (en) is not loading with RequireJS (AMD) #914

nao-pon commented Mar 18, 2018

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018 •

edited

Loading

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018 •

edited

Loading

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018 •

edited

Loading

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018 •

edited

Loading

ma2ciek commented Mar 20, 2018

nao-pon commented Mar 20, 2018

ma2ciek commented Mar 21, 2018 •

edited

Loading

Reinmar commented Mar 21, 2018

pomek commented Mar 22, 2018

Reinmar commented Mar 22, 2018

pomek commented Mar 22, 2018

ma2ciek commented Mar 22, 2018

Reinmar commented Mar 26, 2018

Reinmar commented Mar 26, 2018

Reinmar commented Mar 27, 2018

Reinmar commented Apr 10, 2018

nao-pon commented Apr 11, 2018

Reinmar commented Apr 11, 2018

Default language (en) is not loading with RequireJS (AMD) #914

Default language (en) is not loading with RequireJS (AMD) #914

Comments

nao-pon commented Mar 18, 2018

Is this a bug report or feature request? (choose one)

💻 Version of CKEditor

📋 Steps to reproduce

❎ Actual result

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018 • edited Loading

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018 • edited Loading

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018 • edited Loading

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

Reinmar commented Mar 19, 2018

ma2ciek commented Mar 19, 2018

ma2ciek commented Mar 19, 2018 • edited Loading

ma2ciek commented Mar 20, 2018

CKEditor5WebpackPlugin

MultipleLanguageTranslationService (ckeditor5-dev-utils)

TranslationService (ckeditor5-utils)

Builds and samples:

nao-pon commented Mar 20, 2018

ma2ciek commented Mar 21, 2018 • edited Loading

Reinmar commented Mar 21, 2018

pomek commented Mar 22, 2018

Reinmar commented Mar 22, 2018

pomek commented Mar 22, 2018

ma2ciek commented Mar 22, 2018

Reinmar commented Mar 26, 2018

Reinmar commented Mar 26, 2018

Reinmar commented Mar 27, 2018

Reinmar commented Apr 10, 2018

nao-pon commented Apr 11, 2018

Reinmar commented Apr 11, 2018

ma2ciek commented Mar 19, 2018 •

edited

Loading

ma2ciek commented Mar 19, 2018 •

edited

Loading

Reinmar commented Mar 19, 2018 •

edited

Loading

ma2ciek commented Mar 19, 2018 •

edited

Loading

ma2ciek commented Mar 21, 2018 •

edited

Loading