Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use link.defaultProtocol when auto-linking an URL #8079

Closed
jodator opened this issue Sep 15, 2020 · 0 comments · Fixed by #8292
Closed

Use link.defaultProtocol when auto-linking an URL #8079

jodator opened this issue Sep 15, 2020 · 0 comments · Fixed by #8292
Assignees
@pkwasnik
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:link squad:core Issue to be handled by the Core team. support:3 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 37 (v23...

Comments

@jodator
Copy link
Contributor

jodator commented Sep 15, 2020

📝 Provide a description of the improvement

The defaultProtocol configuration option is used in the UI only. I think that this might be used for auto-link probably as well as the use-case is pretty similar.

OTOH we should think that through as I'm unsure whether this should be tied or should we have an option to disable it for auto-link or UI only. I see this as either:

  1. If defaultProtocol is set use the same logic for auto-link as in link UI.
  2. Another (?) configuration option or object for defaultProtocol that could control UI and auto-link behavior separately. If set as String would behave as option 1 but providing an object { autoLink: 'http://', ui: 'https://' } would allow for a fine-grined control.

As for now, option 2, look like overly complicated and 1 looks like a way to go.

Original issue: #7909 (comment)

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. package:link domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Sep 15, 2020
@jodator jodator mentioned this issue Sep 15, 2020
Closed
@Reinmar Reinmar added intro Good first ticket. support:1 An issue reported by a commercially licensed client. labels Sep 18, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Sep 18, 2020
@pkwasnik pkwasnik self-assigned this Oct 16, 2020
@pkwasnik pkwasnik mentioned this issue Oct 20, 2020
Merged
@jodator jodator mentioned this issue Oct 21, 2020
Closed
jodator added a commit that referenced this issue Oct 22, 2020
@jodator
Merge pull request #8292 from ckeditor/i/8079
9a9f9c3 
Fix (link): Auto link feature will now use `link.defaultProtocol` if set. Closes #8079.
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 37 Oct 26, 2020
@lslowikowska lslowikowska added support:3 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:link squad:core Issue to be handled by the Core team. support:3 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 37 (v23.1.0)
Development

Successfully merging a pull request may close this issue.

Use link.defaultProtocol when auto-linking an URL, ckeditor/ckeditor5
4 participants
@Reinmar @jodator @pkwasnik @lslowikowska