Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table properties forms have unstyled headers #6586

Closed
oleq opened this issue Apr 9, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#280
Closed

Table properties forms have unstyled headers #6586

oleq opened this issue Apr 9, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#280
Assignees
@panr
Labels
package:table package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@oleq
Copy link
Member

oleq commented Apr 9, 2020

📝 Provide detailed reproduction steps (if any)

Probably somewhere around ckeditor/ckeditor5-ui@009e8ac#diff-c7c1de47896edc01c4b2d07f0863da7f we lost styles for header labels.

✔️ Expected result

image

❌ Actual result

image

Funny fact: the special characters header looks OK
image.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:theme-lark package:table labels Apr 9, 2020
@oleq oleq added this to the iteration 31 milestone Apr 9, 2020
@oleq oleq assigned panr Apr 9, 2020
@panr
Copy link
Contributor

panr commented Apr 9, 2020 •
edited
Loading

Funny thing... I have problems with labels here, but FormHeader seems to be fine:
image

Fix is on a way

EDIT: Not relevant...

This was referenced Apr 9, 2020
Closed
Closed
Merged
Merged
@panr
Copy link
Contributor

panr commented Apr 9, 2020

OK, it was unnecessary rush... The issue was somewhere else. Should be fine now. Could you check it @oleq.

oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Apr 16, 2020
@oleq
Merge pull request #280 from ckeditor/i/6586
06f6ca5 
Other: Added a missing file for the `FormHeaderView` styles and removed duplicated styles for `SpecialCharactersNavigation` inherited from the the `FormHeaderView` component. Closes ckeditor/ckeditor5#6586.
oleq added a commit to ckeditor/ckeditor5-special-characters that referenced this issue Apr 16, 2020
@oleq
Merge pull request #16 from ckeditor/i/6586
d20907a 
Other: Removed duplicated styling inherited from the `FormHeaderView` component. See ckeditor/ckeditor5#6586.
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #280 from ckeditor/i/6586
c8f37c9 
Other: Added a missing file for the `FormHeaderView` styles and removed duplicated styles for `SpecialCharactersNavigation` inherited from the the `FormHeaderView` component. Closes #6586.
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #16 from ckeditor/i/6586
2910bbc 
Other: Removed duplicated styling inherited from the `FormHeaderView` component. See #6586.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
package:table package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
2 participants
@oleq @panr