Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dangling commas across the project #6246

Closed
oleq opened this issue Feb 13, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#597
Closed

Disable dangling commas across the project #6246

oleq opened this issue Feb 13, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#597
Assignees
@jodator
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 30 (v18...

Comments

@oleq
Copy link
Member

oleq commented Feb 13, 2020 •
edited
Loading

Provide a description of the task

They look awful and ESLint can help us get rid of them https://eslint.org/docs/rules/comma-dangle.

A follow-up of ckeditor/ckeditor5-table#244.
@oleq oleq added the type:task This issue reports a chore (non-production change) and other types of "todos". label Feb 13, 2020
@oleq oleq mentioned this issue Feb 13, 2020
Merged
3 tasks
@jodator jodator added this to the iteration 30 milestone Feb 21, 2020
@jodator jodator self-assigned this Feb 21, 2020
@jodator jodator mentioned this issue Feb 21, 2020
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Feb 25, 2020
@pomek
Merge pull request #597 from ckeditor/i/481
0bd390a 
Feature: Add "eslint-plugin-mocha" rules to the default ESLint configuration and configure `dangling-coma` rule. Closes #481. Closes ckeditor/ckeditor5#6246.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

Successfully merging a pull request may close this issue.

Add eslint-plugin-mocha to eslint configuration. ckeditor/ckeditor5-dev
2 participants
@jodator @oleq