-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table alignment property is not working properly #6179
Comments
Also @oleq's insights on this in the PR: ckeditor/ckeditor5-table#232 (comment). |
There are cases like lists, where we use However, there are also cases like images, medias, tables, where such an item cannot be renamed. Those features are objects and their attributes will never end up on a different element. Therefore, IMO, here we have a bug in the alignment package. It must be smarter convert attributes on elements which are not objects. And perhaps it might also check whether |
Nope :) I've didn't test this feature manually because of no UI (which is fine). Also, this tickets prooves that we're able to iterate fast and find the bugs earlier and that this doesn't hurt us so much :) The problem here was with priorities - if both converters have the same priority then the one added to the build earlier will win (or should win). Here, increasing the table's What was caught here also is a lack of |
The "where to" convert is extracted to: #6197 as it needs some decisions. |
Other: Convert `alignment` table property to a `<figure>` element. Closes ckeditor/ckeditor5#6197. Closes ckeditor/ckeditor5#6179.
same problem , i am using it in nuxt the image can only be in center and right, cannot align it to the left. ive used this for nuxt integration using https://blowstack.com/blog/frameworks/create-ckeditor-5-custom-build for developers who are experiencing the same problem |
Hello from 2024 :) Experienced this today using the nightly build. I can align the table center or right. Left-align does nothing. Tried both in code with |
📝 Provide detailed reproduction steps (if any)
Try to align the table on the latest master using table properties view.
✔️ Expected result
❌ Actual result
📃 Other details
There are a few problems:
alignment
attribute onTable
is picked up byAlignment
plugin converters (:bug:)<figure>
not on<table>
(as now)<table>
styles in the editing area could have less enforcing rules and could allow proposed inline styles.If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: