Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table selection handling: Merge cell split command #6123

Closed
jodator opened this issue Jan 22, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-table#290
Closed

Table selection handling: Merge cell split command #6123

jodator opened this issue Jan 22, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-table#290
Assignees
@jodator
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 31 (v19...

Comments

@jodator
Copy link
Contributor

jodator commented Jan 22, 2020 •
edited by Reinmar
Loading

📝 Provide a description of the improvement

The #6113 consists of a POC of this command. Hence we need to:

  • cover it with tests
  • revive previous MergeCellCommand as those might still be present
  • the merge cells command will be disabled if the selection covers cells from the body and heading section.
  • If a table cell in the selection is spanned but extends over the selection rectangle, the command will be disabled to prevent broken table layout.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. package:table labels Jan 22, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jan 27, 2020
@jodator
Copy link
Contributor Author

jodator commented Jan 29, 2020

Note: The current POC command state is backed up on i/6123 branch.

@jodator jodator mentioned this issue Jan 29, 2020
Closed
@Reinmar Reinmar mentioned this issue Jan 31, 2020
Closed
21 tasks
@jodator jodator mentioned this issue Feb 18, 2020
Closed
@jodator jodator modified the milestones: nice-to-have, iteration 30 Feb 21, 2020
@Reinmar
Copy link
Member

Reinmar commented Feb 21, 2020

TODO:

  • excavate the code that we wrote a long time (i/6123),
  • make sure that it's not possible to merge cells from the header part and the body part of a table,
  • add a split button

@Reinmar
Copy link
Member

Reinmar commented Feb 21, 2020

This can be done in stage II because the marge up/down/left/right are sufficient for now.

@Reinmar Reinmar modified the milestones: iteration 30, next Feb 21, 2020
@jodator jodator assigned jodator and unassigned jodator Feb 25, 2020
@Reinmar Reinmar changed the title Table selection handling: Merge cells command Table selection handling: Merge cell split button + command Mar 24, 2020
@Reinmar Reinmar changed the title Table selection handling: Merge cell split button + command Table selection handling: Merge cell split command Mar 24, 2020
@Reinmar Reinmar mentioned this issue Mar 24, 2020
Closed
@Reinmar Reinmar modified the milestones: next, iteration 31 Mar 26, 2020
@jodator jodator mentioned this issue Mar 27, 2020
Merged
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 1, 2020
@oleq
Merge pull request #290 from ckeditor/i/6123
a5a7d3e 
Feature: Introduced the `MergeCellsCommand`. Closes ckeditor/ckeditor5#6123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6123: The MergeTableCells command ckeditor/ckeditor5-table
2 participants
@Reinmar @jodator