Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the LabeledView instead of LabeledInputView across the project #6110

Closed
oleq opened this issue Jan 22, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#274
Closed

Use the LabeledView instead of LabeledInputView across the project #6110

oleq opened this issue Jan 22, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#274
Assignees
@panr
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table status:discussion
Milestone
iteration 31 (v19...

Comments

@oleq
Copy link
Member

oleq commented Jan 22, 2020

Provide a description of the task

A follow-up of #6049.

When we first created the latter there were limited use cases and it worked fine. As the new table form arrived I discovered we need to label other (non-input) components like drop–downs as well.

I created the LabeledView with some helpers to cover all possible cases (and used in in table (cell) props forms) but I'm not 100% sure about it's interface. Also if we decide to deprecate LabeledInputView there will be lots of (simple) changes across the repos (image, link, media).

Things to decide:

  • Is the component OK? (API/interface)
  • Do we need anything more?
  • Should we deprecate LabeledInputView now?
    • For how long should it exist in our codebase before we remove it?
@oleq oleq added status:discussion package:table domain:ui/ux This issue reports a problem related to UI or UX. labels Jan 22, 2020
@oleq oleq mentioned this issue Jan 22, 2020
Merged
@oleq oleq added this to the iteration 29 milestone Jan 23, 2020
@Reinmar Reinmar modified the milestones: iteration 29, iteration 30 Feb 6, 2020
@Reinmar Reinmar modified the milestones: iteration 30, next Feb 21, 2020
@panr panr self-assigned this Mar 12, 2020
@Reinmar Reinmar modified the milestones: next, iteration 31 Mar 19, 2020
This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
Merged
@panr
Copy link
Contributor

panr commented Mar 23, 2020 •
edited
Loading

There are three major PRs for the issue:

This was referenced Mar 23, 2020
Closed
Merged
jodator added a commit to ckeditor/ckeditor5-ui that referenced this issue Mar 26, 2020
@jodator
Merge pull request #547 from ckeditor/i/6110
5a7aca7 
Other: Rename `LabeledView` component to `LabeledFieldView`. See ckeditor/ckeditor5#6110.

BREAKING CHANGE: `LabeledView` component was renamed to `LabeledFieldView`. Also, its instance of a labeled component's view is available through `LabeledFieldView#fieldView`. It replaced `LabeledView#view`.
jodator added a commit to ckeditor/ckeditor5-media-embed that referenced this issue Mar 26, 2020
@jodator
Merge pull request #96 from ckeditor/i/6110
bc00c8b 
Other: Replaced `LabeledInputView` with `LabeledFieldView`. See ckeditor/ckeditor5#6110.
jodator added a commit to ckeditor/ckeditor5-link that referenced this issue Mar 26, 2020
@jodator
Merge pull request #256 from ckeditor/i/6110
e4e9ba9 
Other: Replaced `LabeledInputView` with `LabeledFieldView`. See ckeditor/ckeditor5#6110.
jodator added a commit to ckeditor/ckeditor5-image that referenced this issue Mar 26, 2020
@jodator
Merge pull request #345 from ckeditor/i/6110
3416fb2 
Other: Replaced `LabeledInputView` with `LabeledFieldView`. See ckeditor/ckeditor5#6110.
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 26, 2020
@jodator
Merge pull request #282 from ckeditor/i/6110
b905aa5 
Other: Replaced `LabeledInputView` with `LabeledFieldView`. See ckeditor/ckeditor5#6110.
jodator added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Mar 26, 2020
@jodator
Merge pull request #274 from ckeditor/i/6110
7df8dec 
Other: Align code to the changes in ckeditor5-ui API. See ckeditor/ckeditor5#6110.
jodator added a commit to ckeditor/ckeditor5-ui that referenced this issue Mar 26, 2020
@jodator
Merge pull request #549 from ckeditor/i/6110-deprecate-labeledinputview
ae08076 
Other: `LabeledInputView` component has been marked as deprecated in favour of use `LabeledFieldView` component instead. See ckeditor/ckeditor5#6110.
@oleq oleq mentioned this issue Apr 6, 2020
Closed
This was referenced Apr 6, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table status:discussion
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6110: Replace LabeledInputView with LabeledFieldView ckeditor/ckeditor5-theme-lark
3 participants
@Reinmar @oleq @panr