Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to default a manual link decorators value #6031

Closed
robclancy opened this issue Dec 24, 2019 · 4 comments · Fixed by ckeditor/ckeditor5-link#258
Closed

Allow to default a manual link decorators value #6031

robclancy opened this issue Dec 24, 2019 · 4 comments · Fixed by ckeditor/ckeditor5-link#258
Assignees
Labels
intro Good first ticket. support:3 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@robclancy
Copy link

https://ckeditor.com/docs/ckeditor5/latest/features/link.html#adding-target-and-rel-attributes-to-external-links

We are using the open in new tab option here but want it to default to true.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@robclancy robclancy added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Dec 24, 2019
@Reinmar Reinmar added this to the nice-to-have milestone Jan 14, 2020
@Reinmar Reinmar added the intro Good first ticket. label Jan 14, 2020
@Reinmar
Copy link
Member

Reinmar commented Jan 14, 2020

Thanks. That's a good idea.

@rodrigofarcas
Copy link

Hi, is this going to make at some point? Many of our users are very interested on this feature.

@lslowikowska lslowikowska added the support:1 An issue reported by a commercially licensed client. label Mar 25, 2020
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 31 Mar 30, 2020
Reinmar added a commit to ckeditor/ckeditor5-link that referenced this issue Apr 7, 2020
Feature: Introduced an option to configure a manual decorator to be "on" by default. Closes ckeditor/ckeditor5#6031.
mlewand pushed a commit that referenced this issue May 1, 2020
Feature: Introduced an option to configure a manual decorator to be "on" by default. Closes #6031.
@robclancy
Copy link
Author

@Reinmar @niegowski I have tested this multiple times now and I still can't see it working.

decorators: {
              addTargetToLinks: {
                mode: 'manual',
                label: 'Open in a new tab',
                defaultValue: true,
                attributes: {
                  target: '_blank',
                  rel: 'noopener noreferrer',
                },
              },

@robclancy
Copy link
Author

Okay so it works when you use the toolbar and click link, which was never really an issue because the user can see to make it a new tab or not easily. The issue is when you paste a link it auto links to be internal. This still happens.

@lslowikowska lslowikowska added support:3 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. support:3 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants